[Bug 294403] security/py-python-nss: fix build for Python 3.12+ (choking on HAVE_STDARG_PROTOTYPES)

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=294403

            Bug ID: 294403
           Summary: security/py-python-nss: fix build for Python 3.12+
                    (choking on HAVE_STDARG_PROTOTYPES)
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Some People
          Priority: ---
         Component: Individual Port(s)
          Assignee: jhale@FreeBSD.org
          Reporter: milios@ccsys.com
          Assignee: jhale@FreeBSD.org
             Flags: maintainer-feedback?(jhale@FreeBSD.org)
 Attachment #269606 maintainer-approval?
             Flags:
             Flags: maintainer-feedback?

Created attachment 269606
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=269606&action=edit
remove ancient/irrelevant preprocessor branch

CPython 3.12 removed HAVE_STDARG_PROTOTYPES from its configure machinery

port is at latest release (2017)

failure looked like:
...
cc -fno-strict-overflow -Wsign-compare -Wunreachable-code -DNDEBUG -O2 -pipe
-march=znver4 -fstack-protector-strong -fno-strict-aliasing -O2 -pipe
-march=znver4 -fstack-protector-strong -fno-strict-aliasing -fPIC
-I/usr/local/include/nss -I/usr/local/include/nspr
-I/usr/local/include/python3.12 -c src/py_nspr_error.c -o
build/temp.freebsd-14.4-RELEASE-p1-amd64-cpython-312/src/py_nspr_error.o
src/py_nspr_error.c:189:23: error: too few arguments provided to function-like
macro invocation
  189 |         va_start(vargs);
      |                       ^
/usr/include/sys/_stdarg.h:42:9: note: macro 'va_start' defined here
   42 | #define va_start(ap, last)      __builtin_va_start((ap), (last))
      |         ^
src/py_nspr_error.c:189:9: warning: call to undeclared library function
'va_start' with type 'void (struct __va_list_tag *, ...)'; ISO C99 and later do
not support implicit function declarations [-Wimplicit-function-declaration]
  189 |         va_start(vargs);
      |         ^
src/py_nspr_error.c:189:9: note: include the header <stdarg.h> or explicitly
provide a declaration for 'va_start'
src/py_nspr_error.c:189:9: warning: expression result unused [-Wunused-value]
  189 |         va_start(vargs);
      |         ^~~~~~~~
src/py_nspr_error.c:225:23: error: too few arguments provided to function-like
macro invocation
  225 |         va_start(vargs);
      |                       ^
/usr/include/sys/_stdarg.h:42:9: note: macro 'va_start' defined here
   42 | #define va_start(ap, last)      __builtin_va_start((ap), (last))
      |         ^
src/py_nspr_error.c:225:9: warning: expression result unused [-Wunused-value]
  225 |         va_start(vargs);
      |         ^~~~~~~~
3 warnings and 2 errors generated.
error: command '/usr/bin/cc' failed with exit code 1
*** Error code 1

-- 
You are receiving this mail because:
You are the assignee for the bug.