[Bug 294320] [NEW PORT] games/suika3: Portable 2D game and visual novel scripting engine

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=294320

--- Comment #4 from Awe Morris <awe@noctvm.io> ---
Hi Benjamin, thank you for reviewing.

Regarding the build system (CMake vs. configure):
There is an upstream policy for these two methods:

- CMake: The build instructions you pointed out are intended
  for static builds (including libpng, libvorbis, etc.),
  primarily for standalone distribution.

- configure && make: This method is specifically designed
  for packaging systems like FreeBSD Ports. It correctly
  links against shared libraries and preserves debug
  information, which is consistent with other packaging
  standards like Debian.

Regarding the sub-projects in external/:

- These are not external dependencies in the traditional sense.
- This repository serves as the UPSTREAM for these components.
- While separate repositories exist for these sub-projects,
  they are maintained and developed primarily within the Suika3
  codebase.
- Improvements and fixes are periodically backported from here
  to the standalone repositories, rather than the other way
  around.
- Therefore, bundling them is the most appropriate way to ensure
  architectural integrity and build stability.

I have also updated the Makefile to fix WWW, GH_PROJECT, and GH_TAGNAME as you
suggested.

Please check and review again.

Best regards,

-- 
You are receiving this mail because:
You are the assignee for the bug.