[Bug 290206] [NEW PORT] devel/semver: Semantic Versioning for modern C++

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=290206

Hiroki Tagato <tagattie@FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tagattie@FreeBSD.org
             Status|New                         |Open

--- Comment #1 from Hiroki Tagato <tagattie@FreeBSD.org> ---
Hi, thanks for a new port submission.

Here are a few comments:
- DISTVERSION should include -rc suffix
  I guess rc means release candidate. So the current version is less than
1.0.0. Including -rc in DISTVERSION will correctly make pkg aware of that.
- Enable test
  I agree that building tests is not necessary for normal users. But it would
be a good idea to do so for those who want them. I would suggest:
  - Change USES=cmake to USES=cmake:testing
  - Add CMAKE_TESTING_ON=SEMVER_OPT_BUILD_TESTS

The rest of the port looks good to me.

-- 
You are receiving this mail because:
You are the assignee for the bug.