[Bug 289992] emulators/virtualbox-ose-additions(-legacy): fix vboxvfs build on 16-CURRENT

From: <bugzilla-noreply_at_freebsd.org>
Date: Sat, 04 Oct 2025 03:56:37 UTC
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=289992

            Bug ID: 289992
           Summary: emulators/virtualbox-ose-additions(-legacy): fix
                    vboxvfs build on 16-CURRENT
           Product: Ports & Packages
           Version: Latest
          Hardware: amd64
                OS: Any
            Status: New
          Severity: Affects Some People
          Priority: ---
         Component: Individual Port(s)
          Assignee: ports-bugs@FreeBSD.org
          Reporter: takahiro.kurosawa@gmail.com

Created attachment 264280
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=264280&action=edit
patch fixing the build

Building vboxvfs.ko on 16-CURRENT now fails:

----
/wrkdirs/usr/ports/emulators/virtualbox-ose-additions/work/VirtualBox-6.1.50/src/VBox/Additions/freebsd/vboxvfs/vboxvfs_vnops.c:1271:9:
error: use of undeclared identifier 'NULLVP'
 1271 |         *vpp = NULLVP;
      |                ^
/wrkdirs/usr/ports/emulators/virtualbox-ose-additions/work/VirtualBox-6.1.50/src/VBox/Additions/freebsd/vboxvfs/vboxvfs_vnops.c:1281:3:
error: call to undeclared function 'VREF'; ISO C99 and later do not support
implicit function declarations [-Werror,-Wimplicit-function-declaration]
 1281 |                 VREF(dvp);
      |                 ^
----

The attached patch fixes the build on 16-CURRENT.
Because VREF() has already been defined as vref() (and NULLVP as NULL) since
11.0,
they can be safely replaced without "#if __FreeBSD_version ...":

https://cgit.freebsd.org/src/tree/sys/sys/vnode.h?h=release/11.0.0&id=671fb7df97631020c42ce55527dc49fffe0656b7#n411

-- 
You are receiving this mail because:
You are the assignee for the bug.