[Bug 284903] net-p2p/transmission and net-p2p/transmission-components update to 4.1.0-Beta.2

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=284903

Benjamin Takacs <nimaje+fbz@bureaucracy.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nimaje+fbz@bureaucracy.de

--- Comment #9 from Benjamin Takacs <nimaje+fbz@bureaucracy.de> ---
(In reply to Rafe from comment #8)

Some improvements to consider:
* instead of changing OPTIONS_FILE, how about changing OPTIONS_NAME to include
the flavor? That would allow using the <options name>_{,UN}SET variables in
make.conf too (I prefer them to OPTIONS_FILE, as I can just set what I consider
important and the rest will use the defaults, make config would save
everything, even the defaults I don't care about as of the time of running)

* switch to qt6

* You shouldn't set MASTER_SITES together with USE_GITHUB=YES
* GH_ACCOUNT and GH_PROJECT already default to ${PORTNAME}, so no need to set
them here
* similar with GH_TAGNAME, it defaults to
${DISTVERSIONPREFIX}${DISTVERSION}${DISTVERSIONSUFFIX} so changing DISTVERSION
to the tag name 4.1.0-beta.3 should make it work without setting GH_TAGNAME too
(added dot before the 3)

* instead of .if and checking FLAVOR you can use <FLAVOR>_USES to add to USES,
some other veriables support that too, for others you could do   <var>+=
${${FLAVOR}_<var>} (see x11/plasma6-plasma-integration for an example)

* it would be nice if the TESTS option could be converted to a  do-test: 
target, would make it compatible with the testing feature
(Mk/Features/testing.mk)

* are the UTILS_CMAKE_BOOL and WEB_CMAKE_BOOL variables used anywhere? I
suspect they are leftovers from when the port used options for its components

-- 
You are receiving this mail because:
You are the assignee for the bug.