[Bug 290541] [NEW PORT] editors/orderless.el: Completion style that matches multiple regexps

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=290541

Joseph Mingrone <jrm@freebsd.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jrm@freebsd.org

--- Comment #2 from Joseph Mingrone <jrm@freebsd.org> ---
Thanks for submitting.

This looks good overall, with one exception.  You're keeping all the port
flavors, but you're not installing any byte-compiled files.  I've included a
proposed change in the inline diff below.  If you're okay with it, I can
incorporate it on commit.

Unless there's a compelling reason to only install the .el files, let's also
install the .elc files, which requires keeping the flavors.

I have similar comments on your other submissions, so I'll wait to hear back
from you here before commenting on those.


diff --git a/editors/orderless.el/Makefile b/editors/orderless.el/Makefile
index c1d7b49fc223..e79c9904dd9c 100644
--- a/editors/orderless.el/Makefile
+++ b/editors/orderless.el/Makefile
@@ -18,14 +18,15 @@ GH_ACCOUNT= oantolin
 GH_PROJECT=    orderless

 NO_ARCH=   yes
-NO_BUILD=  yes

 OPTIONS_DEFINE=    DOCS

+do-build:
+   ${EMACS_CMD} -q --batch -L ${WRKSRC} -f batch-byte-compile ${WRKSRC}/*.el
+
 do-install:
    @${MKDIR} ${STAGEDIR}${PREFIX}/${EMACS_SITE_LISPDIR}
-   ${INSTALL_DATA} ${WRKSRC}/orderless.el
${STAGEDIR}${PREFIX}/${EMACS_SITE_LISPDIR}
-   ${INSTALL_DATA} ${WRKSRC}/orderless-kwd.el
${STAGEDIR}${PREFIX}/${EMACS_SITE_LISPDIR}
+   ${INSTALL_DATA} ${WRKSRC}/*.el ${WRKSRC}/*.elc
${STAGEDIR}${PREFIX}/${EMACS_SITE_LISPDIR}

 post-install-DOCS-on:
    @${MKDIR} ${STAGEDIR}${DOCSDIR}
diff --git a/editors/orderless.el/pkg-plist b/editors/orderless.el/pkg-plist
index 758408b9ea46..5e2866dbb647 100644
--- a/editors/orderless.el/pkg-plist
+++ b/editors/orderless.el/pkg-plist
@@ -1,3 +1,5 @@
 %%EMACS_SITE_LISPDIR%%/orderless-kwd.el
+%%EMACS_SITE_LISPDIR%%/orderless-kwd.elc
 %%EMACS_SITE_LISPDIR%%/orderless.el
+%%EMACS_SITE_LISPDIR%%/orderless.elc
 %%PORTDOCS%%%%DOCSDIR%%/README.org

-- 
You are receiving this mail because:
You are the assignee for the bug.