[Bug 290836] textproc/py-towncrier: Comparison with "<" requires both operands "3.13t" and "3.10" to be numeric

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=290836

            Bug ID: 290836
           Summary: textproc/py-towncrier: Comparison with "<" requires
                    both operands "3.13t" and "3.10" to be numeric
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: Individual Port(s)
          Assignee: nivit@FreeBSD.org
          Reporter: dim@FreeBSD.org
             Flags: maintainer-feedback?(nivit@FreeBSD.org)
          Assignee: nivit@FreeBSD.org

Just because I am crazy I tried building a ports tree with
DEFAULT_VERSIONS+=python3=3.13t in my poudriere make.conf.

This fails in various interesting ways, mostly due to lots of ports requiring
sphinx which does not support anything about python 3.12, but in particular
textproc/py-towncrier died with:

[00:00:02] [Dry Run] Warning: (textproc/py-towncrier): make:
/usr/ports/textproc/py-towncrier/Makefile:28: Comparison with "<" requires both
operands "3.13t" and "3.10" to be numeric

Since being threaded or not doesn't matter for this comparison, a fix similar
to the following seems to work for me:

--- a/textproc/py-towncrier/Makefile
+++ b/textproc/py-towncrier/Makefile
@@ -25,7 +25,7 @@ NO_ARCH=      yes

 .include <bsd.port.pre.mk>

-.if defined(PYTHON_VER) && ${PYTHON_VER} < 3.10
+.if defined(PYTHON_VER) && ${PYTHON_VER:C/t$//} < 3.10
 BUILD_DEPENDS+=       
${PYTHON_PKGNAMEPREFIX}importlib-metadata>=7.1.0:devel/py-importlib-metadata@${PY_FLAVOR}
\
               
${PYTHON_PKGNAMEPREFIX}importlib-resources>=6.4.0:devel/py-importlib-resources@${PY_FLAVOR}
 RUN_DEPENDS+= 
${PYTHON_PKGNAMEPREFIX}importlib-metadata>=7.1.0:devel/py-importlib-metadata@${PY_FLAVOR}
\

-- 
You are receiving this mail because:
You are the assignee for the bug.