[Bug 290767] net-im/ejabberd: rc restart is reloading instead of restarting

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=290767

            Bug ID: 290767
           Summary: net-im/ejabberd: rc restart is reloading instead of
                    restarting
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: Individual Port(s)
          Assignee: ashish@FreeBSD.org
          Reporter: marko.cupac@mimar.rs
             Flags: maintainer-feedback?(ashish@FreeBSD.org)
          Assignee: ashish@FreeBSD.org

Hi,

according to current rc script, `service ejabberd restart` is reloading config
instead of restarting service:

```
reload_cmd="ejabberd_reload"
restart_cmd="ejabberd_reload"

ejabberd_reload()
{
    echo "Restarting $name."
    if ejabberd_checkstatus; then
        su $EJABBERDUSER -c "env ERL_EPMD_ADDRESS=\"${ejabberd_epmd_address}\"
$EJABBERDCTL --node $ejabberd_node reload_config"
    else
        ejabberd_start
    fi
}
```

This is potentially dangerous to users not aware of its behaviour, as `service
ejabberd restart` after upgrade does not start upgraded executable, resulting
in running possibly vulnerable old version even after upgrade and attempted
restart into new version.

Solution is as easy as changing restart_cmd in rc script to actually restart
instead of reload_config. Works for me.

I can send proper patch if maintainer has no objections (eg. there's some
reason for current behviour I'm not aware of).

Best regards,

-- 
You are receiving this mail because:
You are the assignee for the bug.