[Bug 290531] [NEW PORT] multimedia/tenacity: Tenacity is an easy-to-use multi-track audio editor and recorde

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=290531

--- Comment #7 from Hiroki Tagato <tagattie@FreeBSD.org> ---
(In reply to Martin Filla from comment #6)

Hi, the port looks much better now.

There are 3 comments:
- Utilize <OPT>_CMAKE_BOOL instead of CMAKE_ARGS
  The following 9 lines:

.if ${PORT_OPTIONS:MAVX}
CMAKE_ARGS+=    -DAVX:BOOL=TRUE
.endif
.if ${PORT_OPTIONS:MAVX2}
CMAKE_ARGS+=    -DAVX2:BOOL=TRUE
.endif
.if ${PORT_OPTIONS:MAVX512}
CMAKE_ARGS+=    -DAVX512:BOOL=TRUE
.endif

  can be simplified to the following 3 lines:

AVX_CMAKE_BOOL=    AVX
AVX2_CMAKE_BOOL=   AVX2
AVX512_CMAKE_BOOL= AVX512

- Remove GH_PROJECT
  GH_PROJECT is set to PORTNAME by default. So you can safely remove it.

- Is python needed at runtime?
  It appears there are no python files installed. If python is needed only for
building, use USES=python:build for avoiding unnecessary runtime dependency.

-- 
You are receiving this mail because:
You are the assignee for the bug.