[Bug 285838] net/syncthing: cannot update to 1.29.4

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=285838

--- Comment #9 from Anton Saietskii <vsasjason@gmail.com> ---
(In reply to Dan Langille from comment #6)

> Your patch was not used because I did not notice it.
It's a pity tbh, I feel like wasted some time...

> I tried 1.23 based on a suggestion in this thread <...>
Ok, I agree that test was started earlier on your side, however no results have
been posted at the moment of me finding this PR, so I, despite deep night, just
wanted to fix this immediately and did my own patch.

> Looking at the patch now, why is so much stuff being moved around? Most
> of the changes are reordering existing code. What is the goal of that
> please?
That is actually _the_ goal -- to put variables in their relevant Makefile
sections and in correct order.

(In reply to Dan Langille from comment #7)
> I ask about moving because neither portfmt or portlint make any
> changes.
In fact it does (in the form of portclippy, which is a part of portfmt):
> portclippy Makefile

PORTREVISION
CATEGORIES
MASTER_SITES
DISTNAME

# Maintainer block
MAINTAINER
COMMENT
WWW

# License block
LICENSE
LICENSE_FILE

# USES block
USES
USE_RC_SUBR

# Make block
+MAKE_ENV
-PLIST_FILES
-PORTDOCS

# WRKSRC block
+NO_WRKSUBDIR

# Users and groups block
USERS
GROUPS

# Packaging list block
+PLIST_FILES
+PORTDOCS
-MAKE_ENV

# Options definitions
OPTIONS_DEFINE

-NO_WRKSUBDIR

# Out of order targets
do-build:
+do-install:
do-test:
-do-install:

Usage of both portclippy and portfmt programs suggested in section 10.3. of
Porter's Handbook [0].

[0]:
https://docs.freebsd.org/en/books/porters-handbook/book/#testing-portclippy

-- 
You are receiving this mail because:
You are the assignee for the bug.