[Bug 286588] mail/opendmarc general port cleanup

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=286588

            Bug ID: 286588
           Summary: mail/opendmarc general port cleanup
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: Individual Port(s)
          Assignee: ports-bugs@FreeBSD.org
          Reporter: freebsd@gushi.org

in #280931 (which was about adding a dependency on publicsuffixlist), a few
other changes were proposed, general cleanup stuff re:whitespace and modern
standards.  I'm opening this bug to track those.

- fix warnings from portclippy,
Straightforward, I'll do that in my own time (i.e. not on this issue).
I think I last tested this with only portlint (and poudriere testport).
I can create separate commits: 1) add dns/public_suffix_list only, 2) "improve
port" with all other changes.

2.
- adjust whitespaces,
Could you clarify?
Align values in LICENSE* variables, remove/add several empty lines.

3.
- remove GNU_CONFIGURE_MANPREFIX,
I didn't know that was a thing, but sure, can do that (again, outside of scope
for this issue)
This was temporarily added during the man migration from "${PREFIX}/man" to
"${PREFIX}/share/man".
Since the migration has long been completed and the default value of this
variable is the same "${PREFIX}/share", it must be deleted, which is what we do
when we update a port.

4.
- use "${DISTVERSION:S/./-/g}" in GH_TAGNAME instead of hardcoded version
"1-4-2":
Can also do that!

-- 
You are receiving this mail because:
You are the assignee for the bug.