[Bug 286566] net/minidlna: fix use of quoted literals following sqlite new string quoting policy

From: <bugzilla-noreply_at_freebsd.org>
Date: Sun, 04 May 2025 08:40:21 UTC
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=286566

            Bug ID: 286566
           Summary: net/minidlna: fix use of quoted literals following
                    sqlite new string quoting policy
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Some People
          Priority: ---
         Component: Individual Port(s)
          Assignee: glebius@FreeBSD.org
          Reporter: mazhe@alkumuna.eu
          Assignee: glebius@FreeBSD.org
             Flags: maintainer-feedback?(glebius@FreeBSD.org)

Created attachment 260140
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=260140&action=edit
Fix string literals quoting for sqlite > 3.41.0

Hi,

A few months ago, a new sqlite3 version in ports to forbid to use double-quotes
for strings fields, something previously allowed and used in many codebases
(https://www.sqlite.org/quirks.html#double_quoted_string_literals_are_accepted
for more information).

This also impacts net/minidlna which will work with previously scanned files,
but won't add new ones and output sqlite errors in the log file.

I've tracked the error messages and updated the queries to use single-quote for
string literals in queries, things are working as far as I use minidlna, see
attached patch file. It did not touch any new file in pkg-list-ing, but here's
poudriere output:

====> Running Q/A tests (stage-qa)
====> Checking for pkg-plist issues (check-plist)
===> Parsing plist
===> Checking for items in STAGEDIR missing from pkg-plist
===> Checking for items in pkg-plist which are not in STAGEDIR
===> No pkg-plist issues found (check-plist)
=>> Checking for staging violations... done

Have a nice day,

-- 
You are receiving this mail because:
You are the assignee for the bug.