[Bug 288152] databases/mongosh: update 2.3.8 → 2.5.5

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=288152

Hiroki Tagato <tagattie@FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tagattie@FreeBSD.org
             Status|New                         |Open

--- Comment #1 from Hiroki Tagato <tagattie@FreeBSD.org> ---
(In reply to Fabien Amelinck from comment #0)

Hi Fabien, thanks for an update to the port.

Here are some comments:
- I would advise against using /tmp directory
  Maybe ${WRKDIR}/tmp is better since there are no guarantee that /tmp is
writable during port build. See
https://docs.freebsd.org/en/books/porters-handbook/book/#porting-wrkdir
- There are some direct use of command (make, grep, awk, ...) in
node-modules-archive target
  It would be better using variables defined in bsd.commmands.mk where
applicable.

> Can you please tell me if I can improve the end of the Makefile to check Node's options?

Nothing better I can think of. So it would be fine keeping as it is.

-- 
You are receiving this mail because:
You are the assignee for the bug.