[Bug 288411] [NEW PORT] devel/jjui: A terminal user interface for Jujutsu

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=288411

--- Comment #4 from Al Hoang <hoanga@gmail.com> ---
(In reply to Hiroki Tagato from comment #2)
Hi Hiroki,

Thanks for providing feedback. It was quite helpful in gaining a (little) more
understanding of good conventions for ports.


Why MODVERSION?

After looking at multiple other Go-based ports, I had noticed some of the
Go-based ports were using MODVERSION and based my submission on that (working)
example which might not be the best approach. Perhaps the other ports needed
the extra indirection for some other reasons but in jjui's case this looks
completely unnecessary, in retrospect. 

Why BIN_NAME? Why use MODVERSION?

Similar answer(s) as above.


I have submitted an updated patchset that incorporates your feedback and
provides a (hopefully) cleaner and simplified Makefile

-- 
You are receiving this mail because:
You are the assignee for the bug.