[Bug 288330] [NEW PORT] databases/fmptools: FileMaker Pro conversion suite

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=288330

--- Comment #3 from Daniel Engberg <diizzy@FreeBSD.org> ---
It's getting better,

Personal preference but I would change MASTER_SITES,
https://github.com/evanmiller/fmptools/releases/download/v${DISTVERSION}/ -->
https://github.com/evanmiller/${PORTNAME}/releases/download/v${DISTVERSION}/

Keep WWW as it is however for convenience if you want to copy the URL

Drop the local LICENSE_FILE and entry, while preferred it's not mandatory and
we don't want to host random files from upstream in local repo. Another option
would be to fetch it additionally but that adds more complexity than its worth.

As there are no other options I don't see the need for grouping options?

Sort OPTIONS_DEFAULT in alphabetical order and grouping of variables related to
options in Makefile, ordering within each group is already correct

JSON...

SQLITE...

XSLX ...

If I understand the patch correctly fmpdump doesn't get installed by default?
If that's the case I'd suggest that you drop the patch and install it by using 

post-install:
        ${INSTALL_PROGRAM} ${BUILD_WRKSRC}/fmpdump ${STAGEDIR}${PREFIX}/bin

https://docs.freebsd.org/en/books/porters-handbook/book/#options-targets
https://docs.freebsd.org/en/books/porters-handbook/book/#install-macros

Best regards,
Daniel

-- 
You are receiving this mail because:
You are the assignee for the bug.