[Bug 288425] net/minidlna: fails in configure due to spaces in its Makefile.am introduced in latest commit

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=288425

            Bug ID: 288425
           Summary: net/minidlna: fails in configure due to spaces in its
                    Makefile.am introduced in latest commit
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: Individual Port(s)
          Assignee: glebius@FreeBSD.org
          Reporter: russo@bogodyn.org
          Assignee: glebius@FreeBSD.org
             Flags: maintainer-feedback?(glebius@FreeBSD.org)

In commit
https://github.com/glebius/minidlna/commit/1a2dfccc367649f772e6952aeee1d280a1d5e81d,
a set of conditionals were added to the upstream Makefile.am that fail in
configure on FreeBSD 13.5-STABLE.  The port was updated to use this commit just
today.

Uname:
FreeBSD xxx.xx 13.5-STABLE FreeBSD 13.5-STABLE stable/13-n259335-42dd8f4add1f
GENERIC amd64

Symptom: 
When building the port, configure fails:
---
...
config.status: executing depfiles commands
config.status: error: in '/usr/ports/net/minidlna/work/minidlna-1a2dfcc':
config.status: error: Something went wrong bootstrapping makefile fragments
    for automatic dependency tracking.  If GNU make was not used, consider
    re-running the configure script with MAKE="gmake" (or whatever is
    necessary).  You can also try re-running configure with the
    '--disable-dependency-tracking' option to at least be able to build
    the package (albeit without support for automatic dependency tracking).
See 'config.log' for more details
---

According to config.log, it's failing here:
---
config.status:1334: cd .       && sed -e '/# am--include-marker/d' Makefile     
    | make -f - am--depfiles
make: "(stdin)" line 1137: Invalid line type
make: "(stdin)" line 1138: Invalid line type
---

If one runs the "sed" command there manually one sees that lines 1137 and 1138
are exactly:
  if HAVE_KQUEUE
  endif


Make hates the spaces at the beginning of the lines.

Removing the spaces from the lines in the original Makefile.am fixes the
problem.

I have a patch to the port that fixes it, but it should be fixed upstream as
well.  The attached patch (formatted with git-format-patch) makes the port
configure and build properly on my system.

-- 
You are receiving this mail because:
You are the assignee for the bug.