[Bug 288167] net-mgmt/smartctl_exporter: multiple issues

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=288167

            Bug ID: 288167
           Summary: net-mgmt/smartctl_exporter: multiple issues
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Some People
          Priority: ---
         Component: Individual Port(s)
          Assignee: delphij@FreeBSD.org
          Reporter: vsasjason@gmail.com
          Assignee: delphij@FreeBSD.org
             Flags: maintainer-feedback?(delphij@FreeBSD.org)

1. portlint/portclippy/portfmt complains

3. USES=go:1.23, while default version is 1.24, and it will likely always be
latest (commit 8cb04a4d7a4e76c9ffcb71a50aa73e64712ffc59).

2. GO_MODULES= has been set, however there's no such variable in go.mk, so it
does nothing. Correct name is GO_MODULE, which I believe will eliminate the
need of GH_TUPLE.

3. rc.d script unconditionally sets '--smartctl.device=', which in turn has 2
issues:
3.1. Using this command line options disables automatic device rescans.
3.2. Using 'geom disk status' (and kern.disks sysctl) is wrong in case of NVMe
drives -- one can't request S.M.A.R.T. data from device nodes ({nvd,nda}X). The
controller name (nvmeX) should be used instead.

Unfortunately, I didn't succeed with patch yet, but above still needs to be
fixed.

-- 
You are receiving this mail because:
You are the assignee for the bug.