[Bug 287986] [NEW PORT] x11/wayst, Simple terminal emulator for Wayland and X11

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=287986

--- Comment #5 from Hiroki Tagato <tagattie@FreeBSD.org> ---
(In reply to seafork from comment #4)

Thanks for updating the patch.

Here are some comments:
- Check the Makefile with portclippy (which comes with ports-mgmt/portfmt)
  The ordering of variables should be fixed.
- Respect CFLAGS
  The Makefile supplied by upstream does not respect CFLAGS set by the ports
framework. Please see
https://docs.freebsd.org/en/books/porters-handbook/book/#dads-cflags and patch
the upstream Makefile.
- Installed binary is not stripped
  `make stage-qa` gives the following warning:
  Warning: 'bin/wayst' is not stripped consider trying
INSTALL_TARGET=install-strip or using ${STRIP_CMD}
  In this case, it seems appropriate to strip the binary in post-install stage.

-- 
You are receiving this mail because:
You are the assignee for the bug.