[Bug 287985] net/samba422 samba 4.22.2 WIP Port

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=287985

            Bug ID: 287985
           Summary: net/samba422 samba 4.22.2 WIP Port
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
               URL: https://wiki.samba.org/index.php/Samba_Features_added/
                    changed#Samba_4.22
                OS: Any
            Status: New
          Keywords: needs-qa
          Severity: Affects Some People
          Priority: ---
         Component: Individual Port(s)
          Assignee: ports-bugs@FreeBSD.org
          Reporter: andrej@ebert.su
                CC: samba@FreeBSD.org
 Attachment #261844 maintainer-approval?(samba@FreeBSD.org)
             Flags:
                CC: samba@FreeBSD.org

Created attachment 261844
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=261844&action=edit
samba 4.22, tdb 1.4.13, talloc 2.4.3, tevent 0.17

This is very much a work in progress, but it builds, installs and runs cleanly.
Upgrade on my productive AD-DC went without a hitch.
Joining a (virtual) Windows 10 Client also worked. zfs-backed shares and ACLs
also work for me. 

Didn't test replication, domain provision or join (as DC or otherwise).

Changelogs:

https://wiki.samba.org/index.php/Samba_Features_added/changed#Samba_4.21

https://wiki.samba.org/index.php/Samba_Features_added/changed#Samba_4.22

Port changes from samba420:

- Integrated the fdescfs patch from bug #284623, comment #20

- Removed patch-python_samba_tdb__util.py (this was upstreamed for 4.20,21 and
22: https://bugzilla.samba.org/show_bug.cgi?id=15804)

- Removed  patch-lib_util_wscript__build and patch-source3_wscript__build
(Didn't apply cleanly anymore)

- disabled following patches in the Makefile:

0013-Pass-additional-msg-parameter-to-CHECK_LIB-so-it-can.patch (didn't apply
cleanly anymore)

0026-vfs-add-a-compatibility-option-to-the-vfs_streams_xa.patch (didn't apply
cleanly anymore)

0028-Fix-rl_completion_func_t.patch  (didn't apply cleanly anymore)

0100-Fix-pathref-handling-for-FreeBSD-13plus_samba42x.patch:-p1 and
0101-FreeBSD-add-fdescfs-paths-workaround.patch:-p1 (these 2 are disabled by
the patch by Andrea Venturoli)


Makefile changes:

net/samba422 now conflicts with databases/ldb*, and the 
patch-lib_ldb_wscript is removed. ldb is now bundled and private per default,
as upstream recommends. 
The only consumer of databases/ldb ist sssd, maybe a samba port option (and
flavour?) to make ldb public and let sssd link against that would be a way
forward? Also see bug #280773.

There's an unconditional depedency on devel/icu now, since Samba pulls it in if
it's there  and complains afterwards if icu is bumped without a samba rebuild.

Removed GSSAPI Builtin converters/p5-JSON build dependency, it's not needed
since 4.20 as per upstream:

https://www.samba.org/samba/history/samba-4.20.0.html

Changed the LDAP_CONFIGURE options to --with-ldap/--without-ldap, the
--with-openldap was patched in by the removed patch 0013.

Additional patches:

patch-lib_util_util_crypt_c so it finds the right headers (as seen in the
OpenBSD Ports:
https://github.com/openbsd/ports/blob/master/net/samba/patches/patch-lib_util_util_crypt_c)

patch-source3_modules_vfs__zfsacl.c by Peter Eriksson from
https://bugzilla.samba.org/show_bug.cgi?id=15376 (This finally fixes setting
ACLs from Windows for us, which was broken since 4.19)

Also I had to add recent versions of talloc, tdb and tevent to the ports tree.

Please test, and maybe we'll finally have a recent working Samba version in the
tree.

-- 
You are receiving this mail because:
You are the assignee for the bug.