[Bug 291630] devel/forgejo-runner: 15 releases behind upstream and broken rc script, missing dirs

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=291630

            Bug ID: 291630
           Summary: devel/forgejo-runner: 15 releases behind upstream and
                    broken rc script, missing dirs
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Some People
          Priority: ---
         Component: Individual Port(s)
          Assignee: ports-bugs@FreeBSD.org
          Reporter: me@jcpsantiago.xyz
                CC: daniel@morante.net
                CC: daniel@morante.net
             Flags: maintainer-feedback?(daniel@morante.net)

Created attachment 266156
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=266156&action=edit
Update to 12.1.2 and fix missing dirs and rc script

There are several issues with this port at the moment:

- It is 15 releases behind upstream, including some security fixes
- DATADIR (/var/db/act_runner) is not created with the correct ownership
- The log dir (/var/log/act_runner) is not created at all, which prevents the
service from starting
- The pid cannot be created in /var/run/act_runner.pid because the daemon is
started with an unprivileged user
- The service cannot start using daemon(1) because it cannot set the
environment

I fixed all of the above in the provided patch.

NOTE: I don't understand why the fix for the last point was removing -u from
the daemon(1) invocation. I assume there is some conflict between the rc system
and daemon(1), but I'm not sure, so please educate me.

I contacted Daniel, the maintainer, but did not get a reply, so I'm sharing a
patch here. It's the first time I'm opening a bug report and sharing a patch
for a port, so please correct me if I failed in some part of the procedure (I
did read the handbook, formatted the Makefile, linted, tested locally, etc).

-- 
You are receiving this mail because:
You are the assignee for the bug.