[Bug 291490] www/angie: use upstream version numbers for modules

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=291490

            Bug ID: 291490
           Summary: www/angie: use upstream version numbers for modules
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Some People
          Priority: ---
         Component: Individual Port(s)
          Assignee: ports-bugs@FreeBSD.org
          Reporter: sko@rostwald.de
 Attachment #265992 maintainer-approval+
             Flags:

Created attachment 265992
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=265992&action=edit
www-angie_use-upstream-version-numbers-for-modules.patch

Angie modules currently inherit the version number of the angie version they
are built against. This makes it hard and opaque to track their actual version.
The mechanism used in the Makefile also had the unwanted side-effect of
PORTREVISION propagating from modules to the master port, which broke the build
(we found out the hard way...)

This patch fixes this by changing all angie-module-* ports to their own,
distinct versions and them being reflected in the port/package-version.
To ensure rebuilding/updating of modules when www/angie gets updated, all
module-ports now have www/angie with the current version set under RUN_DEPENDS.

To ensure all modules are updated after this change, despite many having
effectively lower upstream versions than the current angie version, I decided
to introduce PORTEPOCH to all module ports.
We could selectively set this only for ports that have a lower version number,
but for the sake of sanity and POLA, I think it is much cleaner to have all
modules on the same EPOCH.

The patch also adds WWW and the correct LICENSE to all modules (if applicable),
which was previously absent and all modules inherited BSD2CLAUSE from the
master port.


www/angie and all www/angie-module-* ports build fine for me with this patch on
14.3-RELEASE and latest ports tree.
It would be appreciated if some people could give additional feedback if this
also works for them and/or if/how the way I handle the upstream versions (via
ANGIE_VERSION and MODULE_VERSION) can/should be improved. I tried quite a lot
of different approaches and the whole process had caused me several gray hairs,
so I ultimately settled for this approach, as it was IMHO the most transparent
and easy to grasp for everyone looking at the Makefile.

-- 
You are receiving this mail because:
You are the assignee for the bug.