[Bug 288879] [NEW PORT] net/turbovnc-server TurboVNC server

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=288879

--- Comment #4 from Hiroki Tagato <tagattie@FreeBSD.org> ---
(In reply to freebsd-bugs from comment #3)

Thanks for an update. Great improvements!

Let me add some more minor comments:
- Regarding USES=python
  pkg-plist does not list any python files so I guess python is only required
for building the port. If so, please use USES=python:build to avoid unnecessary
runtime-dependency on python.
- Regarding CONFLICTS
  Can this be narrowed to CONFLICTS_INSTALL as it does not appear the presence
of tigervnc/tightvnc causes a build error? Also, tigervnc should read
tigervnc-server?
- Regarding post-stage
  ${ECHO_MGS} can be used instead of direct use of echo.
  ${STAGEDIR}/${LOCALBASE} should read ${STAGEDIR}${PREFIX}.
- Regarding pkg-plist
  make makeplist seems to have messed up some part of pkg-plist.
%%ETCDIR%%server-security.conf and %%ETCDIR%%server.conf should read as follows
respectively:
  etc/turbovncserver-security.conf
  etc/turbovncserver.conf

-- 
You are receiving this mail because:
You are the assignee for the bug.