[Bug 268132] [NEW PORT] audio/grandorgue: Virtual Pipe Organ Software

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=268132

Hiroki Tagato <tagattie@FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tagattie@FreeBSD.org

--- Comment #23 from Hiroki Tagato <tagattie@FreeBSD.org> ---
(In reply to tuc03516 from comment #22)

Hi, thanks for submitting a new port proposal.

Here are some comments:
- Remove MASTER_SITES and DISTNAME
  They are redundant since USE_GITHUB=yes is used
  Add GH_ACCOUNT=GrandOrgue
  Remove GH_PROJECT=grandorgue since it is defaulted to PORTNAME
- It seems dependencies need some cleanup
  Remove devel/cmake from BUILD_DEPENDS since USES=cmake is defined
  Remove devel/pkgconf from BUILD_DEPENDS and specify USES=pkgconfig instead
  Specify executable or filename needed during build-time in BUILD_DEPENDS
  Specify executable or filename needed during run-time in RUN_DEPENDS
  Some dependencies are specified multiple times as BUILD_, LIB_, or
RUN_DEPENDS. Can you check if they are specified as a single dependency? For
example, audio/jack is specified as BUILD_ and LIB_DEPENDS. Couldn't it be
simplified as LIB_DEPENDS only?
- There is no need to specify LIB_DEPENDS multiple times
  x11-toolkits/wxgtk32 is specified in LIB_DEPENDS four times. Just one entry
is enough here.
- Use CMAKE_OFF for FALSE boolean args instead of CMAKE_ARGS
  The three CMAKE_ARGS can be written like:
  CMAKE_OFF= USE_INTERNAL_PORTAUDIO \
             USE_INTERNAL_RTAUDIO \
             USE_INTERNAL_ZITACONVOLVER
- Move USES above USE_GITHUB line
- Is pkg-message file really necessary?
  audio/jack_umidi is specified as RUN_DEPENDS so jack_umidi is available at
run-time. No warning about jack_umidi appears necessary?

-- 
You are receiving this mail because:
You are the assignee for the bug.