[Bug 288495] [NEW PORT] emulators/Ymir: Sega Saturn emulator

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=288495

--- Comment #13 from Stefan Schlosser <bsdcode@disroot.org> ---
Comment on attachment 262733
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=262733
All libs unbundled, flavored gtk3 and gtk4

1) Oof, just not linking against tomlplusplus.so is wild. But it does indeed
work and allows to use it from ports. Build and playtesting is fine, the toml
configuration is read and written correctly.

I completely removed add_subdirectory/find_package tomlplusplus from
vendor/CMakeLists.txt, because it's picked up without any additions now.

2) Flavoring works, thanks for that. This is definitly better than requiring
the user to manually install one of the zenity packages.

To be more in line with the examples given in the Porter's Handbook, I used
"gtk3" and "gtk4" directly instead of ${FLAVORS:[X]} for
PKGNAMESUFFIX/BR_DEPENDS/etc... I find it also a little bit more readable.

Prefixed "gtk_{3,4}_BR_DEPENDS" with "_" to signal the ports framework that
it's a "private" variable. portclippy would complain about it otherwise.

-- 
You are receiving this mail because:
You are the assignee for the bug.