[Bug 288679] x11/hypridle Bug, Fix & Patch Proposal

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=288679

            Bug ID: 288679
           Summary: x11/hypridle Bug, Fix & Patch Proposal
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Some People
          Priority: ---
         Component: Individual Port(s)
          Assignee: tagattie@FreeBSD.org
          Reporter: fgorter@gmail.com
          Assignee: tagattie@FreeBSD.org
             Flags: maintainer-feedback?(tagattie@FreeBSD.org)

Created attachment 262721
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=262721&action=edit
hypridle core dump fix and ConsoleKit2 fix

Hi folks,

Some among you guys are Hyprland pilgrims, because reasons.
You will have noticed that the hypridle port has been broken for some time,
Mostly complaining about some illegal hardware instruction... started at some
point passed Hyprland 0.42 / 0.43 -- if memory serves.
In any case, here's a fix that deals with both the (Linux-y) spurious "Login1"
config -- useless, I suspect to most FreeBSD. My proposed patch offer a fix to
correctly integrate with our ports' ConsoleKit2. The second fix of this patch
is to deal with the "illegal hardware instruction" -- or whatever it is called.
There's been a hacky fix that provides us with a fully functional Hypridle. I
know too little to know about programming this source, to understand why it is
so hacky... but I've trialed it for over half a year, on different machines,
with no ill results.
The core dump will appear as: "zsh: illegal hardware instruction (core dumped)
hypridle"  -- or similar, depending if your shell does something
different/funny.
The hacky fix, is to add a modification that tests for a mutex lock/unlock
loop, via:  "m_sEventLoopInternals.loopRequestMutex.try_lock();"  (See the
patch for location, as it is *not* trivial).
The patch content was produced by GNOME's Meld app, for simplicity. I have
tested it successfully for both the x11/hypridle -- as it appears in our ports
tree & also when simply fetching the repo from GitHub.
Credit for the core-dump investigation and fix belongs to "xorander00" for
https://github.com/hyprwm/hypridle/issues/68 
I can confirm this fix works for Hyprland 0.45 / 0.46 / 0.47 / 0.48 / 0.50.x --
and obviously hypridle versions from he preceding 8+ months.
It is run exactly the same way as proposed by the Hyprland dev team.
Cheers!

-- 
You are receiving this mail because:
You are the assignee for the bug.