[Bug 285604] net/jwhois: Depends on deprecated libidn

From: <bugzilla-noreply_at_freebsd.org>
Date: Mon, 28 Apr 2025 19:32:08 UTC
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=285604

--- Comment #13 from Terry Kennedy <terry-freebsd@glaver.org> ---
(In reply to Daniel Engberg from comment #12)
We're getting pretty far afield from the original request of "Can you please
sync with "upstream" so we can move to libidn2?"

My first patch and my minor tweak to your patch both achieve that, your patch
in a manner that much more closely matches the style in the Porter's Handbook.

Can we just call it a day and go with "Slightly revised V3 patch to remove
autoreconf usage"? It fixes the original issue and uses libidn2, builds both
with and without NLS, and (based on my testing) works fine. 

If you still want to delve into this further, I think the issue may be that the
patch-configure in files/ that deals with LTLIBINTL is getting undone when
autoreconf rebuilds things. 

But the details of autoconf, etc. are outside my skillset. I will point out
that the port distfile was built with automake 1.9.6 while we have 1.17, and
autoconf 2.50 while we have 2.72, and even when it was built with the older
versions, there were a lot of "warning: The macro 'FOO' is obsolete. You should
run autoupdate." I can certainly see why it is failing when our autoreconf is
used - the question is whether or not someone should delve into the multiple
layers of ancient configuration scripts to bring it up to something that works
with modern autoreconf.

I think the fact that upstream hasn't addressed this is a strong indication
that it will be a lot of work for no real-world change.

-- 
You are receiving this mail because:
You are the assignee for the bug.