[Bug 285604] net/jwhois: Depends on deprecated libidn

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=285604

--- Comment #10 from Terry Kennedy <terry-freebsd@glaver.org> ---
(In reply to Daniel Engberg from comment #9)
I agree with most of the above. I have a few comments, which range from minor
to a showstopper. They're based on building on 14.2-STABLE.

o I agree with all changes to bring the port more inline with the current
Handbook style.

o The original distinfo isn't 404-ing for me. But I agree we should track the
latest upstream, even though in this case the contents are the same.

o No objection to applying jwhois-4.0-gcc15-fix.patch although the number of
people who will build this port with gcc 15 seems minimal (at best). It doesn't
seem to reduce the number of clang warnings.

o USES=autoreconf looks like a good idea (and doing a Make without it generates
a bunch of messages about doing so), but breaks the build. This is what you
mentioned about Poudriere. It isn't Poudriere that is causing the problem, it
is autoreconf. This is from a simple standalone "make" with autoreconf:

ld: error: undefined symbol: libintl_bindtextdomain
>>> referenced by jwhois.c
>>>               jwhois-jwhois.o:(main)

ld: error: undefined symbol: libintl_gettext
>>> referenced by cache.c
>>>               jwhois-cache.o:(cache_init)
>>> referenced by cache.c
>>>               jwhois-cache.o:(cache_init)
>>> referenced by jwhois.c
>>>               jwhois-jwhois.o:(main)
>>> referenced 58 more times

ld: error: undefined symbol: libintl_textdomain
>>> referenced by jwhois.c
>>>               jwhois-jwhois.o:(main)
cc: error: linker command failed with exit code 1 (use -v to see invocation)
gmake[2]: *** [Makefile:440: jwhois] Error 1
gmake[2]: Leaving directory '/usr/ports/net/jwhois/work/jwhois-4.0/src'
gmake[1]: *** [Makefile:441: all-recursive] Error 1
gmake[1]: Leaving directory '/usr/ports/net/jwhois/work/jwhois-4.0'
gmake: *** [Makefile:380: all] Error 2
===> Compilation failed unexpectedly.
Try to set MAKE_JOBS_UNSAFE=yes and rebuild before reporting the failure to
the maintainer.
*** Error code 1

Stop.
make[1]: stopped in /usr/ports/net/jwhois
*** Error code 1

Stop.
make: stopped in /usr/ports/net/jwhois

This does not happen when we don't have USES=autoreconf.

I am attaching a patch which includes all of your changes except for
autoreconf. This builds successfully both with and without NLS.

-- 
You are receiving this mail because:
You are the assignee for the bug.