[Bug 285352] [NEW PORT] filesystems/befuse: FUSE server for Be File System

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=285352

--- Comment #8 from Robert Clausecker <fuz@FreeBSD.org> ---
(In reply to Krutarth Patel from comment #7)

Thank you for your response.  Here are some items to check:

 - Why is this port marked as ONLY_FOR_ARCHS=amd64?  Our policy is to use
   ONLY_FOR_ARCHS only if it is known that the port cannot possibly work on
   other architectures than the ones listed.  Merely not knowing whether the
   port works elsewhere is insufficient cause for setting this variable.
   As I see no reason for the port not working elsewhere, I will disregard
   this variable.

 - there should be no need to set CMAKE_INSTALL_PREFIX and INSTALL_TARGET as
   the values you set these to are the default values.

 - by convention, fuse file systems should have PKGNAMEPREFIX set to fusefs-

 - WWW can be omitted if it points to the github project page as that is the
   default for ports using USE_GITHUB

Here are some problems in the code base I found:

 - headers/private/fs_shell/fssh_api_wrapper.h redefines various errno values.
   That is usually a mistake.  Errno values are platform dependent and
redefining
   them will yield defective error handling.

 - a test build on arm64 FreeBSD 15-CURRENT fails as follows:

/usr/home/ports/main.ports/filesystems/befuse/work/befuse-1.1/src/befuse/fuse.cpp:193:46:
error: use of undeclared identifier 'FUSE_FILL_DIR_DEFAULTS'; did you mean
'FUSE_FILL_DIR_PLUS'?
  193 |                         if (filler(buf, dirEntry->d_name, &st, 0,
FUSE_FILL_DIR_DEFAULTS))
      |                                                                  
^~~~~~~~~~~~~~~~~~~~~~
      |                                                                  
FUSE_FILL_DIR_PLUS
/usr/local/include/fuse3/fuse.h:67:2: note: 'FUSE_FILL_DIR_PLUS' declared here
   67 |         FUSE_FILL_DIR_PLUS = (1 << 1)
      |         ^
1 error generated.

Please check these issues and resubmit.

-- 
You are receiving this mail because:
You are the assignee for the bug.