[Bug 284988] [new port] audio/cubeb: Cross platform audio library
- In reply to: bugzilla-noreply_a_freebsd.org: "[Bug 284988] [new port] audio/cubeb: Cross platform audio library"
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Sat, 05 Apr 2025 22:46:21 UTC
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=284988
Daniel Engberg <diizzy@FreeBSD.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |diizzy@FreeBSD.org
--- Comment #8 from Daniel Engberg <diizzy@FreeBSD.org> ---
Having a quick look...
Remove USE_CXXSTD
https://github.com/mozilla/cubeb/blob/master/CMakeLists.txt#L27
GH_TAGNAME should use a short hash
https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-master_sites-github
CMAKE_ARGS+= should be CMAKE_OFF=
https://docs.freebsd.org/en/books/porters-handbook/book/#using-cmake
LDFLAGS+= should be SNDIO_USES= localbase:ldflags
https://cgit.freebsd.org/ports/tree/Mk/Uses/localbase.mk
OPT_CMAKE_ON/OFF should be OPT_CMAKE_BOOL (see Porters Handbook)
Nothing G(oogle)test or GMock related should ever be installed by the port
Libraries should be shared no static
Project doesn't utilize rust/cargo to build?
--
You are receiving this mail because:
You are the assignee for the bug.