[Bug 281540] devel/sfml: fix build with libc++ 19

From: <bugzilla-noreply_at_freebsd.org>
Date: Mon, 16 Sep 2024 18:00:10 UTC
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=281540

            Bug ID: 281540
           Summary: devel/sfml: fix build with libc++ 19
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Some People
          Priority: ---
         Component: Individual Port(s)
          Assignee: amdmi3@FreeBSD.org
          Reporter: dim@FreeBSD.org
          Assignee: amdmi3@FreeBSD.org
             Flags: maintainer-feedback?(amdmi3@FreeBSD.org)

As noted in the libc++ 19 release notes [1], std::char_traits<> is now
only provided for char, char8_t, char16_t, char32_t and wchar_t, and any
instantiation for other types will fail.

This causes devel/sfml to fail to compile with clang 19 and libc++ 19,
resulting in errors similar to:

  /usr/include/c++/v1/string:820:42: error: implicit instantiation of undefined
template 'std::char_traits<unsigned int>'
    820 |   static_assert(is_same<_CharT, typename
traits_type::char_type>::value,
        |                                          ^
 
/wrkdirs/usr/ports/devel/sfml/work/SFML-2.6.1/include/SFML/System/String.hpp:52:18:
note: in instantiation of template class 'std::basic_string<unsigned int>'
requested here
     52 |     typedef std::basic_string<Uint32>::iterator       Iterator;     
//!< Iterator type
        |                  ^
  /usr/include/c++/v1/__fwd/string.h:23:29: note: template is declared here
     23 | struct _LIBCPP_TEMPLATE_VIS char_traits;
        |                             ^

SFML makes heavy use of the no-longer-existing basic_string variants, so
I had to add a rudimentary set of char_traits classes, for unsigned
char, unsigned short and unsigned int, otherwise this would not compile.

[1] https://libcxx.llvm.org/ReleaseNotes/19.html#deprecations-and-removals

-- 
You are receiving this mail because:
You are the assignee for the bug.