[Bug 282733] [NEW PORT] textproc/dmenu-translate: Quick text translation with dmenu

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=282733

Yusuf Yaman <nxjoseph@protonmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #255475|0                           |1
        is obsolete|                            |

--- Comment #6 from Yusuf Yaman <nxjoseph@protonmail.com> ---
Created attachment 255487
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=255487&action=edit
textproc/dmenu-translate.patch

You are welcome and thanks for explaining things to fix with references and in
a detailed way.

> do not invent a version number when upstream doesn't have one, instead follow
> the example given in § 5.4.3 "USE_GITHUB" Example 17.

Thanks, done.

> use the full git hash for GH_TAGNAME so it's unambiguous in any case

done.

> prefer DISTVERSION over PORTVERSION if possible

done.

> please check the grammar of your option descriptions; perhaps something like
> this would work?

i just used yours.

> our mktemp does not support --tempdir.  Please check the manual.  Perhaps you
> want "mktemp -d dmenu-translate.XXXXXX'

Hmm, it seem to work for me, man page of mktemp says:

     -p tmpdir, --tmpdir[=tmpdir]
             Use tmpdir for the -t flag if the TMPDIR environment variable is
             not set.  Additionally, any provided template arguments will be
             interpreted relative to the path specified as tmpdir.  If tmpdir
             is either empty or omitted, then the TMPDIR environment variable
             will be used.

> I'm sorry for not catching these issues earlier.

No problem.

-- 
You are receiving this mail because:
You are the assignee for the bug.