[Bug 282880] textproc/amberfish: update to 1.7.1, take maintainership

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=282880

--- Comment #4 from Robert Clausecker <fuz@FreeBSD.org> ---
(In reply to nrn from comment #3)

Thank you for improving your patch.

If I run portlint on the patch you submitted, I get a whole lot of errors and
warnings:

WARN: Makefile: [5]: USE_* seen before USES.  According to the
porters-handbook, USES must appear first.
WARN: Makefile: [33]: possible direct use of command "echo" found. use
${ECHO_CMD} or ${ECHO_MSG} instead.
FATAL: Makefile: extra item "USE_GITLAB" placed in the MAINTAINER section.
FATAL: Makefile: extra item "GL_COMMIT" placed in the MAINTAINER section.
WARN: Makefile: COMMENT is set externally to this port's Makefile, but this
port is not configured as a slave port.
FATAL: Makefile: extra item "MAINTAINER" placed in the LICENSE section.
FATAL: Makefile: extra item "COMMENT" placed in the LICENSE section.
FATAL: Makefile: extra item "WWW" placed in the LICENSE section.
WARN: Makefile: "LICENSE_FILE" has to appear earlier.
WARN: Makefile: "LICENSE_FILE" has to appear earlier.
WARN: Makefile: "LICENSE" has to appear earlier.
WARN: Makefile: "LICENSE_FILE" has to appear earlier.
WARN: Makefile: "LIB_DEPENDS" has to appear earlier.
WARN: Makefile: "USES" has to appear earlier.
5 fatal errors and 9 warnings found.

The error is that USE_GITLAB=yes and GL_COMMIT go a bit further below in the
Makefile, right after USES=...  Also, GL_TAGNAME should be used instead of
GL_COMMIT.

It also warns you to use ${ECHO_CMD} instead of echo, which is something that
also needs to be fixed.

Are you sure you ran the tool correctly?  It has to be run in the directory of
the port with no arguments.  Please make sure you fix the errors and possibly
warnings raised by portlint.

A build test passed, but there are stage-qa warnings you did not address:

====> Running Q/A tests (stage-qa)
Warning: 'bin/af' is not stripped consider trying INSTALL_TARGET=install-strip
or using ${STRIP_CMD}
Warning: you might not need LIB_DEPENDS on libxerces-c.so

You can use ${STRIP_CMD} in post-install to fix that, or remove the patch that
stops the program from being stripped.

And the plist is incorrect, as reported by "make check-plist":

====> Checking for pkg-plist issues (check-plist)
===> Parsing plist
===> Checking for items in STAGEDIR missing from pkg-plist
Error: Orphaned: share/man/man3/afclose.3.gz
Error: Orphaned: share/man/man3/afgetresultmd.3.gz
Error: Orphaned: share/man/man3/afopen.3.gz
Error: Orphaned: share/man/man3/afsearch.3.gz
Error: Orphaned: share/man/man3/afsortdocid.3.gz
Error: Orphaned: share/man/man3/afsortscore.3.gz

Are you sure you actually ran "make stage-qa" and "make check-plist"?

Poudriere should be able to fetch the distfile if the upstream site is
configured correctly.  For your patch, it looks like it is; I was able to build
the port just fine using Poudriere.  Maybe DISTFILES_CACHE is configured to
something unexpected in /usr/local/etc/poudriere.conf?  That's where poudriere
places the distfiles, not in the jails.

-- 
You are receiving this mail because:
You are the assignee for the bug.