[Bug 282645] graphics/povray37: fix build with libc++ 19

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=282645

--- Comment #4 from commit-hook@FreeBSD.org ---
A commit in branch 2024Q4 references this bug:

URL:
https://cgit.FreeBSD.org/ports/commit/?id=fa64477e6c3f80ff90f2e661fdd1a2c0de0ee8b2

commit fa64477e6c3f80ff90f2e661fdd1a2c0de0ee8b2
Author:     Dimitry Andric <dim@FreeBSD.org>
AuthorDate: 2024-11-09 12:04:23 +0000
Commit:     Dimitry Andric <dim@FreeBSD.org>
CommitDate: 2024-11-21 23:11:13 +0000

    graphics/povray37: fix build with libc++ 19

    As noted in the libc++ 19 release notes [1], std::char_traits<> is now
    only provided for char, char8_t, char16_t, char32_t and wchar_t, and any
    instantiation for other types will fail.

    This causes graphics/povray37 to fail to compile with clang 19 and
    libc++ 19, resulting in errors similar to:

      /usr/include/c++/v1/string:820:42: error: implicit instantiation of
undefined template 'std::char_traits<unsigned short>'
        820 |   static_assert(is_same<_CharT, typename
traits_type::char_type>::value,
            |                                          ^
      ./base/configbase.h:159:19: note: in instantiation of template class
'std::basic_string<unsigned short>' requested here
        159 | inline UCS2String ASCIItoUCS2String(const char *s)
            |                   ^
      /usr/include/c++/v1/__fwd/string.h:23:29: note: template is declared here
         23 | struct _LIBCPP_TEMPLATE_VIS char_traits;
            |                             ^

    This can be fixed by defining `POVMSUCS2` as `char16_t` instead of
    `unsigned short`, `UCS2` as `char16_t` instead of `unsigned short`, and
    `UCS4` as `char32_t` instead of `unsigned int` in the passed-in
    `CPPFLAGS` variable.

    Also, patch up `vfe.cpp` and `vfeconf.h` to use `char16_t` and
    `u16string` instead of the non-standard types.

    [1] https://libcxx.llvm.org/ReleaseNotes/19.html#deprecations-and-removals

    PR:             282645
    Approved by:    bsd@philippost.de (maintainer)
    MFH:            2024Q4

    (cherry picked from commit 6133473e4227abbfcf023bea6ab5eeed9c17e55b)

 graphics/povray37/Makefile                        |  3 +++
 graphics/povray37/files/patch-vfe_vfe.cpp (new)   | 26 +++++++++++++++++++++++
 graphics/povray37/files/patch-vfe_vfeconf.h (new) | 19 +++++++++++++++++
 3 files changed, 48 insertions(+)

-- 
You are receiving this mail because:
You are the assignee for the bug.