[Bug 282326] [NEW PORT] x11/sx: Start an X.Org Server

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=282326

Vlad Biley <bileslav@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #254826|0                           |1
        is obsolete|                            |

--- Comment #7 from Vlad Biley <bileslav@gmail.com> ---
Created attachment 254912
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=254912&action=edit
x11/sx: Add new port

Fixed patch:

* added WWW (see below)
* added NO_ARCH (reported by poudriere-testport)
* moved NO_BUILD (reported by portclippy)
* formatted Makefile (used portfmt)

(In reply to Alastair Hogge from comment #5)

>the word "Added" (diff segment header), this is meant to indicate that the following is new

Yes, but you may also see the two-pane (+/-) view with a blue background,
rather than a single-pane (+) view with a green background like the others.

>Did you run your Port thru the various Port tools, portlint(1), portfmt(1), portclippy(1), and poudriere-testport(8)?

Only portlint. Now I have used all of this, thank you for the references. I
have not yet had a time to study the full Porter's Handbook, where I see these
tools are recommended.

By the way, in my opinion, that whitespace alignment of Makefiles is debatable.
But of course if there are rules, I will follow them.

>I believe reviews.freebsd.org. is the preferred place for new Ports too.

The Handbook recommends submitting ports here:
https://docs.freebsd.org/en/books/porters-handbook/quick-porting/#porting-submitting

Is that information out of date?

(In reply to Alastair Hogge from comment #6)

>The sx Makefile is also missing ${WWW}.

I thought that with ports using GitHub the WWW is not required, as I discovered
that in this case the framework automatically constructs WWW from
GH_ACCOUNT/PORTNAME. There are also such ports in the tree, but I have just
found that most of the ports specify WWW regardless of USE_GITHUB, so now I
decided to add it too. Although this still seems a bit redundant to me.

-- 
You are receiving this mail because:
You are the assignee for the bug.