[Bug 282476] emulators/open-vm-tools: fix build with libc++ 19

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=282476

            Bug ID: 282476
           Summary: emulators/open-vm-tools: fix build with libc++ 19
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Some People
          Priority: ---
         Component: Individual Port(s)
          Assignee: garga@FreeBSD.org
          Reporter: dim@FreeBSD.org
             Flags: maintainer-feedback?(garga@FreeBSD.org)
          Assignee: garga@FreeBSD.org

As noted in the libc++ 19 release notes [1], std::char_traits<> is now
only provided for char, char8_t, char16_t, char32_t and wchar_t, and any
instantiation for other types will fail.

This causes emulators/open-vm-tools to fail to compile with clang 19 and libc++
19,
resulting in errors similar to:

  /usr/include/c++/v1/string:820:42: error: implicit instantiation of undefined
template 'std::char_traits<unsigned short>'
    820 |   static_assert(is_same<_CharT, typename
traits_type::char_type>::value,
        |                                          ^
  ./stringxx/string.hh:270:18: note: in instantiation of template class
'std::basic_string<unsigned short>' requested here
    270 |    return string(lhs) + rhs;
        |                  ^
  /usr/include/c++/v1/__fwd/string.h:23:29: note: template is declared here
     23 | struct _LIBCPP_TEMPLATE_VIS char_traits;
        |                             ^

This can be fixed by using the standard type std::u16string for UTF-16
strings, instead of (effectively) std::basic_string<uint16_t>.

[1] https://libcxx.llvm.org/ReleaseNotes/19.html#deprecations-and-removals

-- 
You are receiving this mail because:
You are the assignee for the bug.