[Bug 280398] chinese/librime: Port defines conflicing C++ standards

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=280398

            Bug ID: 280398
           Summary: chinese/librime: Port defines conflicing C++ standards
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: Individual Port(s)
          Assignee: khng@freebsd.org
          Reporter: diizzy@FreeBSD.org
             Flags: maintainer-feedback?(khng@freebsd.org)
          Assignee: khng@freebsd.org

Upstream project hardcodes c++17
https://github.com/rime/librime/blob/1.11.2/CMakeLists.txt#L177
It would be nice if upstream CMake's framework for this,
https://cmake.org/cmake/help/latest/prop_tgt/CXX_STANDARD.html#prop_tgt:CXX_STANDARD

Port makefile defines, c++14
https://github.com/rime/librime/blob/1.11.2/CMakeLists.txt#L177
https://cgit.freebsd.org/ports/tree/chinese/librime/Makefile#n26

We should probably remove references for c++14 in port Makefile, update USES to
c++17 and preferably submit a patch upstream or ask upstream to update their
code.

-- 
You are receiving this mail because:
You are the assignee for the bug.