[Bug 280298] net/miniupnpc: in 2.2.8 changed API for UPNP_GetValidIGD: build error net-p2p/transmission-components and other

In reply to: bugzilla-noreply_a_freebsd.org: "[Bug 280298] net-p2p/transmission-components: build error after updating net/miniupnpc to 2.2.8"
Go to: [ bottom of page ] [ top of archives ] [ this month ]
From: <bugzilla-noreply_at_freebsd.org>
Date: Tue, 16 Jul 2024 15:25:15 UTC
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=280298

Alex <alex@awel.us> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |alex@awel.us

--- Comment #30 from Alex <alex@awel.us> ---
I still do not believe this was fixed. Using a freshly updated ports tree:

I have updated miniupnpc to 2.2.8

[root@meatwad 11:22 transmission-components]$  pkg info | grep mini             
miniupnpc-2.2.8                UPnP IGD client lightweight library

when I run:

[root@meatwad 11:22 transmission-components]$  make FLAVOR=daemon reinstall
clean

I get an error around the area it is calling miniupnpc

usr/local/include/utf8cpp -isystem
/usr/ports/net-p2p/transmission-components/work-daemon/transmission-4.0.6/cmake/../third-party/wide-integer
-O2 -pipe -DLIBICONV_PLUG -fstack-protector-strong -isystem /usr/local/include
-fno-strict-aliasing  -DLIBICONV_PLUG -isystem /usr/local/include -O2 -pipe
-DLIBICONV_PLUG -fstack-protector-strong -isystem /usr/local/include
-fno-strict-aliasing  -DLIBICONV_PLUG -isystem /usr/local/include  -DNDEBUG
-std=gnu++17 -W -Wall -Wextra -Wcast-align -Wexit-time-destructors -Wextra-semi
-Wextra-semi-stmt -Wextra-tokens -Wfloat-equal -Wgnu -Winit-self
-Wint-in-bool-context -Wmissing-format-attribute -Wnull-dereference
-Wpointer-arith -Wredundant-decls -Wredundant-move -Wreorder-ctor
-Wreturn-std-move -Wself-assign -Wself-move -Wsemicolon-before-method-body
-Wsentinel -Wshadow -Wsign-compare -Wsometimes-uninitialized
-Wstring-conversion -Wsuggest-destructor-override -Wsuggest-override
-Wuninitialized -Wunreachable-code -Wunused -Wunused-const-variable
-Wunused-parameter -Wunused-result -Wwrite-strings -Wformat-security -pthread
-MD -MT libtransmission/CMakeFiles/transmission.dir/port-forwarding-upnp.cc.o
-MF libtransmission/CMakeFiles/transmission.dir/port-forwarding-upnp.cc.o.d -o
libtransmission/CMakeFiles/transmission.dir/port-forwarding-upnp.cc.o -c
/usr/ports/net-p2p/transmission-components/work-daemon/transmission-4.0.6/libtransmission/port-forwarding-upnp.cc
/usr/ports/net-p2p/transmission-components/work-daemon/transmission-4.0.6/libtransmission/port-forwarding-upnp.cc:278:13:
error: no matching function for call to 'UPNP_GetValidIGD'
  278 |         if (UPNP_GetValidIGD(devlist, &handle->urls, &handle->data,
std::data(lanaddr), std::size(lanaddr) - 1) ==
      |             ^~~~~~~~~~~~~~~~
/usr/local/include/miniupnpc/miniupnpc.h:122:1: note: candidate function not
viable: requires 7 arguments, but 5 were provided
  122 | UPNP_GetValidIGD(struct UPNPDev * devlist,
      | ^                ~~~~~~~~~~~~~~~~~~~~~~~~~
  123 |                  struct UPNPUrls * urls,
      |                  ~~~~~~~~~~~~~~~~~~~~~~~
  124 |                  struct IGDdatas * data,
      |                  ~~~~~~~~~~~~~~~~~~~~~~~
  125 |                  char * lanaddr, int lanaddrlen,
      |                  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  126 |                  char * wanaddr, int wanaddrlen);
      |                  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
[  6% 4/29] /usr/bin/c++ -DFMT_EXCEPTIONS=0 -DFMT_HEADER_ONLY=1
-DHAVE_COPY_FILE_RANGE -DHAVE_FLOCK -DHAVE_LIBINTL_H -DHAVE_MKDTEMP
-DHAVE_POSIX_FADVISE -DHAVE_POSIX_FALLOCATE -DHAVE_PREAD -DHAVE_PWRITE
-DHAVE_SO_REUSEPORT=1 -DHAVE_STATVFS -DHAVE_SYS_STATVFS_H -DHAVE_XLOCALE_H
-DPACKAGE_DATA_DIR=\"/usr/local/share\" -DSYSTEM_MINIUPNP -DUSE_SYSTEM_B64
-DWIDE_INTEGER_DISABLE_FLOAT_INTEROP -DWIDE_INTEGER_DISABLE_IOSTREAM
-DWITH_KQUEUE -DWITH_UTP -D__TRANSMISSION__
-I/usr/ports/net-p2p/transmission-components/work-daemon/.build/libtransmission
-I/usr/ports/net-p2p/transmission-components/work-daemon/transmission-4.0.6/third-party/jsonsl
-I/usr/ports/net-p2p/transmission-components/work-daemon/transmission-4.0.6/third-party/wildmat
-isystem /usr/local/include/utf8cpp -isystem
/usr/ports/net-p2p/transmission-components/work-daemon/transmission-4.0.6/cmake/../third-party/wide-integer
-O2 -pipe -DLIBICONV_PLUG -fstack-protector-strong -isystem /usr/local/include
-fno-strict-aliasing  -DLIBICONV_PLUG -isystem /usr/local/include -O2 -pipe
-DLIBICONV_PLUG -fstack-protector-strong -isystem /usr/local/include
-fno-strict-aliasing  -DLIBICONV_PLUG -isystem /usr/local/include  -DNDEBUG
-std=gnu++17 -W -Wall -Wextra -Wcast-align -Wexit-time-destructors -Wextra-semi
-Wextra-semi-stmt -Wextra-tokens -Wfloat-equal -Wgnu -Winit-self
-Wint-in-bool-context -Wmissing-format-attribute -Wnull-dereference
-Wpointer-arith -Wredundant-decls -Wredundant-move -Wreorder-ctor
-Wreturn-std-move -Wself-assign -Wself-move -Wsemicolon-before-method-body
-Wsentinel -Wshadow -Wsign-compare -Wsometimes-uninitialized
-Wstring-conversion -Wsuggest-destructor-override -Wsuggest-override
-Wuninitialized -Wunreachable-code -Wunused -Wunused-const-variable
-Wunused-parameter -Wunused-result -Wwrite-strings -Wformat-security -pthread
-MD -MT libtransmission/CMakeFiles/transmission.dir/torrent-metainfo.cc.o -MF
libtransmission/CMakeFiles/transmission.dir/torrent-metainfo.cc.o.d -o
libtransmission/CMakeFiles/transmission.dir/torrent-metainfo.cc.o -c
/usr/ports/net-p2p/transmission-components/work-daemon/transmission-4.0.6/libtransmission/torrent-metainfo.cc
[ 10% 4/29] /usr/bin/c++ -DFMT_EXCEPTIONS=0 -DFMT_HEADER_ONLY=1
-DHAVE_COPY_FILE_RANGE -DHAVE_FLOCK -DHAVE_LIBINTL_H -DHAVE_MKDTEMP
-DHAVE_POSIX_FADVISE -DHAVE_POSIX_FALLOCATE -DHAVE_PREAD -DHAVE_PWRITE
-DHAVE_SO_REUSEPORT=1 -DHAVE_STATVFS -DHAVE_SYS_STATVFS_H -DHAVE_XLOCALE_H
-DPACKAGE_DATA_DIR=\"/usr/local/share\" -DSYSTEM_MINIUPNP -DUSE_SYSTEM_B64
-DWIDE_INTEGER_DISABLE_FLOAT_INTEROP -DWIDE_INTEGER_DISABLE_IOSTREAM
-DWITH_KQUEUE -DWITH_UTP -D__TRANSMISSION__
-I/usr/ports/net-p2p/transmission-components/work-daemon/.build/libtransmission
-I/usr/ports/net-p2p/transmission-components/work-daemon/transmission-4.0.6/third-party/jsonsl
-I/usr/ports/net-p2p/transmission-components/work-daemon/transmission-4.0.6/third-party/wildmat
-isystem /usr/local/include/utf8cpp -isystem
/usr/ports/net-p2p/transmission-components/work-daemon/transmission-4.0.6/cmake/../third-party/wide-integer
-O2 -pipe -DLIBICONV_PLUG -fstack-protector-strong -isystem /usr/local/include
-fno-strict-aliasing  -DLIBICONV_PLUG -isystem /usr/local/include -O2 -pipe
-DLIBICONV_PLUG -fstack-protector-strong -isystem /usr/local/include
-fno-strict-aliasing  -DLIBICONV_PLUG -isystem /usr/local/include  -DNDEBUG
-std=gnu++17 -W -Wall -Wextra -Wcast-align -Wexit-time-destructors -Wextra-semi
-Wextra-semi-stmt -Wextra-tokens -Wfloat-equal -Wgnu -Winit-self
-Wint-in-bool-context -Wmissing-format-attribute -Wnull-dereference
-Wpointer-arith -Wredundant-decls -Wredundant-move -Wreorder-ctor
-Wreturn-std-move -Wself-assign -Wself-move -Wsemicolon-before-method-body
-Wsentinel -Wshadow -Wsign-compare -Wsometimes-uninitialized
-Wstring-conversion -Wsuggest-destructor-override -Wsuggest-override
-Wuninitialized -Wunreachable-code -Wunused -Wunused-const-variable
-Wunused-parameter -Wunused-result -Wwrite-strings -Wformat-security -pthread
-MD -MT libtransmission/CMakeFiles/transmission.dir/torrent-files.cc.o -MF
libtransmission/CMakeFiles/transmission.dir/torrent-files.cc.o.d -o
libtransmission/CMakeFiles/transmission.dir/torrent-files.cc.o -c
/usr/ports/net-p2p/transmission-components/work-daemon/transmission-4.0.6/libtransmission/torrent-files.cc
[ 13% 4/29] /usr/bin/c++ -DFMT_EXCEPTIONS=0 -DFMT_HEADER_ONLY=1
-DHAVE_COPY_FILE_RANGE -DHAVE_FLOCK -DHAVE_LIBINTL_H -DHAVE_MKDTEMP
-DHAVE_POSIX_FADVISE -DHAVE_POSIX_FALLOCATE -DHAVE_PREAD -DHAVE_PWRITE
-DHAVE_SO_REUSEPORT=1 -DHAVE_STATVFS -DHAVE_SYS_STATVFS_H -DHAVE_XLOCALE_H
-DPACKAGE_DATA_DIR=\"/usr/local/share\" -DSYSTEM_MINIUPNP -DUSE_SYSTEM_B64
-DWIDE_INTEGER_DISABLE_FLOAT_INTEROP -DWIDE_INTEGER_DISABLE_IOSTREAM
-DWITH_KQUEUE -DWITH_UTP -D__TRANSMISSION__
-I/usr/ports/net-p2p/transmission-components/work-daemon/.build/libtransmission
-I/usr/ports/net-p2p/transmission-components/work-daemon/transmission-4.0.6/third-party/jsonsl
-I/usr/ports/net-p2p/transmission-components/work-daemon/transmission-4.0.6/third-party/wildmat
-isystem /usr/local/include/utf8cpp -isystem
/usr/ports/net-p2p/transmission-components/work-daemon/transmission-4.0.6/cmake/../third-party/wide-integer
-O2 -pipe -DLIBICONV_PLUG -fstack-protector-strong -isystem /usr/local/include
-fno-strict-aliasing  -DLIBICONV_PLUG -isystem /usr/local/include -O2 -pipe
-DLIBICONV_PLUG -fstack-protector-strong -isystem /usr/local/include
-fno-strict-aliasing  -DLIBICONV_PLUG -isystem /usr/local/include  -DNDEBUG
-std=gnu++17 -W -Wall -Wextra -Wcast-align -Wexit-time-destructors -Wextra-semi
-Wextra-semi-stmt -Wextra-tokens -Wfloat-equal -Wgnu -Winit-self
-Wint-in-bool-context -Wmissing-format-attribute -Wnull-dereference
-Wpointer-arith -Wredundant-decls -Wredundant-move -Wreorder-ctor
-Wreturn-std-move -Wself-assign -Wself-move -Wsemicolon-before-method-body
-Wsentinel -Wshadow -Wsign-compare -Wsometimes-uninitialized
-Wstring-conversion -Wsuggest-destructor-override -Wsuggest-override
-Wuninitialized -Wunreachable-code -Wunused -Wunused-const-variable
-Wunused-parameter -Wunused-result -Wwrite-strings -Wformat-security -pthread
-MD -MT libtransmission/CMakeFiles/transmission.dir/torrent-magnet.cc.o -MF
libtransmission/CMakeFiles/transmission.dir/torrent-magnet.cc.o.d -o
libtransmission/CMakeFiles/transmission.dir/torrent-magnet.cc.o -c
/usr/ports/net-p2p/transmission-components/work-daemon/transmission-4.0.6/libtransmission/torrent-magnet.cc
ninja: build stopped: subcommand failed.
===> Compilation failed unexpectedly.
Try to set MAKE_JOBS_UNSAFE=yes and rebuild before reporting the failure to
the maintainer.
*** Error code 1

Stop.
make[2]: stopped in /usr/ports/net-p2p/transmission-components
*** Error code 1

Stop.
make[1]: stopped in /usr/ports/net-p2p/transmission-components
*** Error code 1

Stop.
make: stopped in /usr/ports/net-p2p/transmission-components

-- 
You are receiving this mail because:
You are the assignee for the bug.