From nobody Wed Jan 31 12:11:03 2024 X-Original-To: ports-bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4TQ18p4WpSz58P8J for ; Wed, 31 Jan 2024 12:11:06 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4TQ18p1nqBz4VkT for ; Wed, 31 Jan 2024 12:11:06 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1706703066; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Oul++zJeO6pwOjJRKBGSLQSjic6vWoTnAVel7pTp+4w=; b=YHjf00BYdTpUFW32tPPL0CXBPCEp0bsVzcJZxw0Hin3MgfFPJKs5x55U8mhd7gE51bMcZw QgZC5D78kvhhNfnsZ3QihX9IQFIK7Ge+4vcqv0VJNZowiZdD3NsoeU8V3OnrYEzsL8t/xx Inpp0OJDpg9qqNB/ccZgQeGSBlyeoyjnNjrRTIEzkUfGi6TzAVHztAeNfV8DzB3Jfsz8yr fxsm47ofZiJGKhYov0vlBXLnhb1Ww7F0k5M0kJecQSpn0kTuICV0eqBBjh5ystp7sOzsDt qg/6XM/vrU2KZexoBzTh8lNia/98JJg2p2FXlzfkvrA6eIR/KBWGqdJkpAnpzA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1706703066; a=rsa-sha256; cv=none; b=g7OaAYfbiP+qHHuMRe5UecpRDa7Vy8pZ7y+QYxu02IBVbUKn9i2w5TUqjjnwS8YCF50Hxx nUWgEoxSbt5F3LtLyr5/5KLWk6uiCznDdN6dUNpG8jG8yYEMHsFjpkZ6FJz5mP6BCYIcmg s1/imFGpjp0ORv0DhnPPifJgBXYj7WtTds7AgobMrfMookr+H7z10S6ltTqqSgDCkoVZl4 YDUBwh2eQkktn9nTzfLC3ITzDSdXuuxqhu23mhnDiZYW5prWyonaMCsCupNjUYspiZwk4n 9xnPRXfNC5cyBfB670FmHge/8U4Oi6PYRBESVyV0obZXfFtvSdRYNNgn7i4RsQ== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4TQ18p0w0xzHvJ for ; Wed, 31 Jan 2024 12:11:06 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 40VCB6Us008361 for ; Wed, 31 Jan 2024 12:11:06 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 40VCB6Fd008290 for ports-bugs@FreeBSD.org; Wed, 31 Jan 2024 12:11:06 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 276746] www/firefox: fix build with libc++ 18 Date: Wed, 31 Jan 2024 12:11:03 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: dim@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: gecko@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter flagtypes.name Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Ports bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-ports-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ports-bugs@freebsd.org X-BeenThere: freebsd-ports-bugs@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D276746 Bug ID: 276746 Summary: www/firefox: fix build with libc++ 18 Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Severity: Affects Some People Priority: --- Component: Individual Port(s) Assignee: gecko@FreeBSD.org Reporter: dim@FreeBSD.org Flags: maintainer-feedback?(gecko@FreeBSD.org) Assignee: gecko@FreeBSD.org This fixes two problems in www/firefox related to libc++ 18: * rust-bindgen problems with tuple definitions * visibility issues caused by gcc_hidden.h The first problem is that rust-bindgen uses some tricks to generate bindings for C++ components, but gets confused by some new constructs in libc++ 18 headers, causing it to generate faulty binding code. This is described more fully in ; in the mean time, upstream committed to fix it. The second problem is that the firefox build uses a rather brute force technique to suppress visibility of unwanted symbols in their shared libraries: they include a file config/gcc_hidden.h in front of almost every source file. This file contains nothing but a line containing "#pragma GCC visibility push(hidden)", forcing everything after it to have hidden visibility. This causes link errors with libc++ 18 and later, similar to: ld.lld: error: undefined hidden symbol: std::__1::basic_string, std::__1::allocator>::append(char const*, unsigned long) The issue is described more fully in , but upstream has not been able to decide if it is really a problem on their end, or if they want to support the use case at all. A better way to fix this is by using the more usual -fvisibility command line flags, which are similar in effect, but do not override extern declarations such as the ones in libc++ headers (see also ). This is achieved by patching build/moz.configure/toolchain.configure, to use the -fvisibility=3Dhidden and -fvisibility-inlines-hidden flags on FreeBSD in addition to Darwin. I am considering also sending this upstream. --=20 You are receiving this mail because: You are the assignee for the bug.=