From nobody Sun Jan 14 12:27:15 2024 X-Original-To: ports-bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4TCZKJ1qVmz57nJY for ; Sun, 14 Jan 2024 12:27:16 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4TCZKH5ysFz52HL for ; Sun, 14 Jan 2024 12:27:15 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1705235235; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YyzNzllmtMU+6zL8tORLVHRPBrUl63wLcC+oajc+enA=; b=U9SXsUXKIdy1hGiM9RldiA53LccfiYorkYbHlzNxOcdSxUBpD+S3BireLDceq5ymsEQVKV DoMh1NhT5+bo7V8zmoxgAmO5RObO+M7sM9o6F6PsYcp4sd167E4zk0cknAnhDqNTZzMTZF wU9gY1rin3jYtLMQfkaDRMq2GO+SS4XB5hyRK2w369W9mwNGKofDdQl3gkzS5gWERBesMB jSya3mEtwhvnoEUnldEi0YRC75Le7JYug8lfldyGDudmfw2halUsSFPpmW6XJxWOfg9+ew MQwPXSQf1ac6vKCla/ubgV17lxYz3tqkmlQCX3qVLa9xVRWZeCaORm8Fcs7iIQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1705235235; a=rsa-sha256; cv=none; b=VRafWczCcgYo1fjgwPJWT9JGErKgp+6AE3G3B+apH1mz5MHx5yCWZahGCTKv/RBp/VAYkH b7eHgQUk66GRPyFI5lM5pLMyhx268MQaP4iqNlg/FD9uLIjNHxBdUScbfFImso6NHitIfc wC3DoJUkJIQEUVddNNrH/cCZICj9Z4Ben0V9ndi47iQ2WgSyf6zGM+C4cuTuCEJK63rKNX FzVQ4CQq9oC2lDb8/9UsjNIJMxheKZBZ9IYhqQryYkNhKP55PsVY/KdlQLZYmTbXdALQ/5 QcXYEHs6ZPa71Z70v0DiQLPyYKAKwU7oq6j4eXTlKgOzhdcYXT+cEQ1vZs9pXQ== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4TCZKH51kfz1CKG for ; Sun, 14 Jan 2024 12:27:15 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 40ECRFdo031576 for ; Sun, 14 Jan 2024 12:27:15 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 40ECRF38031571 for ports-bugs@FreeBSD.org; Sun, 14 Jan 2024 12:27:15 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 274813] www/elog: Revive port Date: Sun, 14 Jan 2024 12:27:15 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: fuz@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: ports-bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_status Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Ports bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-ports-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ports-bugs@freebsd.org X-BeenThere: freebsd-ports-bugs@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D274813 Robert Clausecker changed: What |Removed |Added ---------------------------------------------------------------------------- Status|New |Open --- Comment #5 from Robert Clausecker --- Thank you for the update. It seems to address my previous questions. I have since found some time to review your patch: - in a recent change, the MANPREFIX variable has been eliminated. Instead= use ${PREFIX}/share/man (preferred) or ${PREFIX}/man - as your port is currently set up, the daemon configured by the rc.d/elog file runs as root, not the elog user you added. Is this intentional? Try setting=20 elog_user and elog_group in the script to run the daemon with the given user.=20=20 It could also be that your daemon changes the user on its own, I didn't check. - all the files in WWWDIR are owned by elog. This means that if your daem= on runs as that user, all these files are writable by the daemon. This can= be a security problem: if an attacker manages to compromise the elog daemon= , he can persist himself by infecting these files. Unless files need to be written by the elog daemon, it is generally a good idea to give them to root:whe= el as usual. Only give files and directories to elog:elog if they need to be written by the daemon. It is usually best to lay out files such that pa= ths with daemon-writable files and those without are clearly separated. - check if you can place the configuration file in ${PREFIX}/etc as is convention. There can be exceptions, but it's usually better to have t= he configuration in the usual places. - your port installs a server key pair. This is usually wrong: each installation needs its own key pair, so the pair can't be shipped in the binary package. Many daemons can be configured to generate a key pa= ir on first start if none exists. Check if that would do the trick. Alternatively, add a post-install script or some magic to the rc.d scrip= t to generate the key pair after installation. --=20 You are receiving this mail because: You are the assignee for the bug.=