[Bug 276811] u-boot-master used BINARY_ ALIAS with = could we change this to +=?

From: <bugzilla-noreply_at_freebsd.org>
Date: Sat, 03 Feb 2024 19:32:47 UTC
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=276811

            Bug ID: 276811
           Summary: u-boot-master used BINARY_ALIAS with = could we change
                    this to +=?
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: Individual Port(s)
          Assignee: ports-bugs@FreeBSD.org
          Reporter: crb@ChrisBowman.com
                CC: mandree@FreeBSD.org, tijl@FreeBSD.org
                CC: mandree@FreeBSD.org, tijl@FreeBSD.org

I have a port for u-boot that uses the u-boot-master framework however my port
needs to call gdd instead of the system dd.  I want to use BINARY_ALIAS but the
master port Makefile use = instead of += to set its own BINARY_ALIAS thus
blowing away mine.  could we change this?

diff --git a/sysutils/u-boot-master/Makefile b/sysutils/u-boot-master/Makefile
index 646876fdb261..d35cca756ecb 100644
--- a/sysutils/u-boot-master/Makefile
+++ b/sysutils/u-boot-master/Makefile
@@ -28,7 +28,7 @@ BUILD_DEPENDS+=      
e2fsprogs-libuuid>=0:misc/e2fsprogs-libuuid \
                gnutls>=0:security/gnutls

 USES=          bison gmake python:build pkgconfig shebangfix tar:bz2
-BINARY_ALIAS=  bison=${LOCALBASE}/bin/bison dtc=${LOCALBASE}/bin/dtc sed=gsed
python3=${PYTHON_CMD}
+BINARY_ALIAS+= bison=${LOCALBASE}/bin/bison dtc=${LOCALBASE}/bin/dtc sed=gsed
python3=${PYTHON_CMD}

 SHEBANG_FILES= tools/binman/binman
 SSP_UNSAFE=    yes

-- 
You are receiving this mail because:
You are the assignee for the bug.