[Bug 281042] textproce/py-sphinx-markdown-tables: LICENSE file installed to ${PREFIX}/LICENSE

From: <bugzilla-noreply_at_freebsd.org>
Date: Sun, 25 Aug 2024 02:41:43 UTC
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=281042

            Bug ID: 281042
           Summary: textproce/py-sphinx-markdown-tables: LICENSE file
                    installed to ${PREFIX}/LICENSE
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Some People
          Priority: ---
         Component: Individual Port(s)
          Assignee: ports-bugs@FreeBSD.org
          Reporter: jcfyecrayz@liamekaens.com

textproce/py-sphinx-markdown-tables installs a LICENSE file to
${PREFIX}/LICENSE after the ports f7213edc202f27211c7400fc59049012cfd72c42
commit (Mar 18, 2024).

That is the wrong place for that file, of course.  But it should not be
installed at all there as the license framework (bsd.license.mk) does the right
things to install the license files in the right place

 - ${PREFIX}/LICENSE is a verbatim copy of
${PREFIX}/share/licenses/py*-sphinx-markdown-tables-<ver>/GPLv3
 - it is a verbatim copy of Templates/Licenses/GPLv3

It looks like the Mar 18, 2024 commit removed files/patch-setup.py which
prevented the install of LICENSE to ${PREFIX}/LICENSE, by commenting out
'data_files' in setup.py.

The fix is to restore files/patch-setup.py

Also LICENSE_FILE is not needed:

diff --git a/textproc/py-sphinx-markdown-tables/Makefile
b/textproc/py-sphinx-markdown-tables/Makefile
index 6a3821d61d3b..fb55ad431b18 100644
--- a/textproc/py-sphinx-markdown-tables/Makefile
+++ b/textproc/py-sphinx-markdown-tables/Makefile
@@ -10,7 +10,6 @@ COMMENT=      Sphinx extension for rendering tables written
in markdown
 WWW=           https://github.com/ryanfox/sphinx-markdown-tables

 LICENSE=       GPLv3
-LICENSE_FILE=  ${WRKSRC}/LICENSE

 RUN_DEPENDS=  
${PYTHON_PKGNAMEPREFIX}markdown>=3.4:textproc/py-markdown@${PY_FLAVOR}

-- 
You are receiving this mail because:
You are the assignee for the bug.