[Bug 281016] www/domoticz-devel: Improve port

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=281016

            Bug ID: 281016
           Summary: www/domoticz-devel: Improve port
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: Individual Port(s)
          Assignee: ports-bugs@FreeBSD.org
          Reporter: diizzy@FreeBSD.org
                CC: kiwi@oav.net
             Flags: maintainer-feedback?(kiwi@oav.net)
                CC: kiwi@oav.net

Created attachment 253045
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=253045&action=edit
Patch for domoticz

Reword and modernize port to follow Porters Handbook more closely (no
functional change)

* Add --no-same-owner --no-same-permissions to EXTRACT_AFTER_ARGS
  https://cgit.freebsd.org/ports/tree/Mk/bsd.port.mk#n705

* Rework and sort OPTIONS 
  See
https://docs.freebsd.org/en/books/porters-handbook/book/#options-cmake_bool

* Remove variables in CMAKE_OFF that are already disabled by default

TELLDUS was removed in 2023
https://cgit.freebsd.org/ports/commit/?id=55660d2e5466486b38bd437a94f5ce5d089a1e2f

Other considerations,

I would suggest to drop PRECOMP and always generate headers, there's less than
1 minute in difference on my rather slow laptop in terms of compile time.

Stage QA complains about REINPLACE_CMD not modifying files

I would also suggest that you follow "Example 18. Using USE_GITHUB to Access a
Commit Between Two Versions" for versioning

-- 
You are receiving this mail because:
You are the assignee for the bug.