[Bug 280820] sysutils/htop: simplify Makefile

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=280820

            Bug ID: 280820
           Summary: sysutils/htop: simplify Makefile
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: Individual Port(s)
          Assignee: ports-bugs@FreeBSD.org
          Reporter: me@svmhdvn.name
                CC: gaod@hychen.org
             Flags: maintainer-feedback?(gaod@hychen.org)
                CC: gaod@hychen.org

Created attachment 252764
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=252764&action=edit
[PATCH] sysutils/htop: simplify Makefile

This change cleans up the Makefile to follow Porter's Handbook guidance. Here
is the rationale for each change:

* As per
https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-master_sites-github,
ports are urged to move to using Github releases instead of git tags. This
change replaces USE_GITHUB with MASTER_SITES to statically point to htop
release tarballs. This also requires the addition of USES=tar:xz

* Remove USES=autoreconf because the release tarball doesn't need to run it

* Remove USES=compiler:c11 since upstream https://github.com/htop-dev/htop
states that a C99 compiler is needed.

* htop does not exist in the official NVD CPE dictionary, so as per
https://docs.freebsd.org/en/books/porters-handbook/book/#uses-cpe, we should
"not ever make up CPE data." Thus, USES=cpe is removed until an entry is
contributed to the CPE dictionary

* USES={libtool,localbase,pkgconfig,python:build,shebangfix} are not necessary
for a successful build and run with the GH release tarball.

* GNU_CONFIGURE_MANPREFIX was unnecessary since the PLIST does correctly
install the manpage to the right location

-- 
You are receiving this mail because:
You are the assignee for the bug.