[Bug 276104] [exp-run] Against llvm-18-update branch on GitHub
- In reply to: bugzilla-noreply_a_freebsd.org: "[Bug 276104] [exp-run] Against llvm-18-update branch on GitHub"
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Thu, 25 Apr 2024 16:48:56 UTC
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=276104
--- Comment #146 from commit-hook@FreeBSD.org ---
A commit in branch main references this bug:
URL:
https://cgit.FreeBSD.org/src/commit/?id=f08bf5a3acf146b17794fbde41279645ddbaa086
commit f08bf5a3acf146b17794fbde41279645ddbaa086
Author: Dimitry Andric <dim@FreeBSD.org>
AuthorDate: 2024-04-25 16:47:31 +0000
Commit: Dimitry Andric <dim@FreeBSD.org>
CommitDate: 2024-04-25 16:47:47 +0000
Merge commit 0f329e0246d1 from llvm-project (by Dimitry Andric):
[sanitizer_symbolizer] Cast arguments for format strings in markup
(#89815)
When compiling the common sanitizer libraries, there are many warnings
about format specifiers, similar to:
compiler-rt/lib/sanitizer_common/sanitizer_symbolizer_markup.cpp:31:32:
warning: format specifies type 'void *' but the argument has type 'uptr' (aka
'unsigned long') [-Wformat]
31 | buffer->AppendF(kFormatData, DI->start);
| ~~~~~~~~~~~ ^~~~~~~~~
compiler-rt/lib/sanitizer_common/sanitizer_symbolizer_markup_constants.h:33:46:
note: format string is defined here
33 | constexpr const char *kFormatData = "{{{data:%p}}}";
| ^~
| %lu
compiler-rt/lib/sanitizer_common/sanitizer_symbolizer_markup.cpp:46:43:
warning: format specifies type 'void *' but the argument has type 'uptr' (aka
'unsigned long') [-Wformat]
46 | buffer->AppendF(kFormatFrame, frame_no, address);
| ~~~~~~~~~~~~ ^~~~~~~
compiler-rt/lib/sanitizer_common/sanitizer_symbolizer_markup_constants.h:36:48:
note: format string is defined here
36 | constexpr const char *kFormatFrame = "{{{bt:%u:%p}}}";
| ^~
| %lu
...
This is because `uptr` is dependent on the platform, and can be either
`unsigned long long`, `unsigned long`, or `unsigned int`.
To fix the warnings, cast the arguments to the expected type of the
format strings.
PR: 276104
Reported by: pstef
MFC after: 3 days
.../lib/sanitizer_common/sanitizer_symbolizer_markup.cpp | 10 ++++++----
.../sanitizer_common/sanitizer_symbolizer_markup_constants.h | 6 +++---
2 files changed, 9 insertions(+), 7 deletions(-)
--
You are receiving this mail because:
You are on the CC list for the bug.