[Bug 278266] [NEW PORT] comms/python-elgato-streamdeck: Python library to control the Elgato Stream Deck

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=278266

Nuno Teixeira <eduardo@FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |eduardo@FreeBSD.org
           Assignee|ports-bugs@FreeBSD.org      |eduardo@FreeBSD.org
             Status|New                         |Open

--- Comment #2 from Nuno Teixeira <eduardo@FreeBSD.org> ---
Hello,

Sugestions:

1. Use PyPI sdist instead of github tarball

2. build, lib, run depends could be corrected to:

BUILD_DEPENDS=  \
    ${PYTHON_PKGNAMEPREFIX}setuptools>0:devel/py-setuptools@${PY_FLAVOR} \
    ${PYTHON_PKGNAMEPREFIX}wheel>0:devel/py-wheel@${PY_FLAVOR}
LIB_DEPENDS=    libhidapi.so:comms/hidapi
RUN_DEPENDS=    \
    ${PYTHON_PKGNAMEPREFIX}pillow>=8.1.1:graphics/py-pillow@${PY_FLAVOR}

Doubts:

1. Is 'elgato-' prefix needed? PyPI package is registered as
https://pypi.org/project/streamdeck/ without prefix. I did some research at
repology.org and found that some linux distros use prefix, others don't.

My opinion is to follow PyPI naming scheme.

2. I'm not familiar with this software but I'm noted that sdist includes a test
suite. Could you check the possiblity of including a test target?

Note: PyPI sdist seems to be in DOS encoding and it might be needed
USES+=dos2unix.

-- 
You are receiving this mail because:
You are the assignee for the bug.