[Bug 276104] [exp-run] Against llvm-18-update branch on GitHub
- In reply to: bugzilla-noreply_a_freebsd.org: "[Bug 276104] [exp-run] Against llvm-18-update branch on GitHub"
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Sat, 20 Apr 2024 10:34:25 UTC
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=276104
--- Comment #97 from commit-hook@FreeBSD.org ---
A commit in branch stable/14 references this bug:
URL:
https://cgit.FreeBSD.org/src/commit/?id=bf13152d9e61246e5a5f494e5cd02bd55cccea80
commit bf13152d9e61246e5a5f494e5cd02bd55cccea80
Author: Dimitry Andric <dim@FreeBSD.org>
AuthorDate: 2024-02-05 09:16:17 +0000
Commit: Dimitry Andric <dim@FreeBSD.org>
CommitDate: 2024-04-19 21:14:15 +0000
Merge commit 5f4ee5a2dfa9 from llvm-project (by Shanzhi):
[Clang][AST] Fix a crash on attaching doc comments (#78716)
This crash is basically caused by calling
`ASTContext::getRawCommentForDeclNoCacheImp` with its input arguments
`RepresentativeLocForDecl` and `CommentsInTheFile` refering to different
files. A reduced reproducer is provided in this patch.
After the source locations for instantiations of funtion template are
corrected in the commit 256a0b298c68b89688b80350b034daf2f7785b67, the
variable `CommitsInThisFile` in the function
`ASTContext::attachCommentsToJustParsedDecls` would refer to the source
file rather than the header file for implicit function template
instantiation. Therefore, in the first loop in
`ASTContext::attachCommentsToJustParsedDecls`, `D` should also be
adjusted for relevant scenarios like the second loop.
Fixes #67979
Fixes #68524
Fixes #70550
This should fix a segfault when compiling graphics/gdal.
PR: 276104
MFC after: 1 month
(cherry picked from commit dc36515b628331e03ac8c23a6749f7f3eb1ebec8)
contrib/llvm-project/clang/lib/AST/ASTContext.cpp | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
--
You are receiving this mail because:
You are on the CC list for the bug.