[Bug 274168] mail/postsrsd: `service postsrsd stop` return 1

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=274168

            Bug ID: 274168
           Summary: mail/postsrsd: `service postsrsd stop` return 1
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: Individual Port(s)
          Assignee: ports-bugs@FreeBSD.org
          Reporter: romain@FreeBSD.org
                CC: ports@bsdserwis.com
                CC: ports@bsdserwis.com
             Flags: maintainer-feedback?(ports@bsdserwis.com)

Dear maintainer,

When stopping the service, the `postsrsd_postcmd()` function in the rc-script
attempts to remove the "/var/run/postsrsd" directory (redirecting stdout and
stderr to /dev/null hiding any error here). But the directory contains the
"postsrsd.pid" file and therefore `rmdir(1)` return the error code 1.

This break configuration management systems that attempt to stop and start the
service: the stop action returning 1, the action is considered a failure.

The rc subsystem checks that process with PID in the pid file correspond to the
actual service, so removing this directory is IMHO not required.  As a
consequence, I think we can remove that function completely.

What do you think?

-- 
You are receiving this mail because:
You are the assignee for the bug.