[Bug 274133] openssh-portable configure test for zlib version is broken in FreeBSD 13.2

From: <bugzilla-noreply_at_freebsd.org>
Date: Wed, 27 Sep 2023 15:55:39 UTC
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=274133

            Bug ID: 274133
           Summary: openssh-portable configure test for zlib version is
                    broken in FreeBSD 13.2
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Keywords: buildisok, toolchain
          Severity: Affects Many People
          Priority: ---
         Component: Individual Port(s)
          Assignee: ports-bugs@FreeBSD.org
          Reporter: hostmaster@whois.gts.net

Created attachment 245292
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=245292&action=edit
proposed fix for zlib version test

Ports & Packages/openssh-portable

# uname -a
FreeBSD fbsd13_2 13.2-STABLE FreeBSD 13.2-STABLE stable/13-n256387-7af7a0d1b14e
GENERIC amd64


openssh-portable zlib test is broken -

1. FBSD 13.2 compiler does not work correctly for this -

        if (n != 3 && n != 4)

... it needs parentheses around each expression to work properly

2. zlib.h has -

        #define ZLIB_VERSION "1.3"

so n == 2 for that string



proposed fix attached

-- 
You are receiving this mail because:
You are the assignee for the bug.