From nobody Tue Sep 19 17:32:22 2023 X-Original-To: ports-bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RqpdM0fyLz4vBSk for ; Tue, 19 Sep 2023 17:32:23 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RqpdL4sX7z3GMp for ; Tue, 19 Sep 2023 17:32:22 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1695144742; a=rsa-sha256; cv=none; b=U80USJtJDx7dGnrtSrElma4Cou+DHkeR25r0EYf2xHGFVu8ic8Iixi2fy6BQDLz+fTonFh zAfsE7J13oIJ4pHiWrLVgzaT7dQyiU4TocXMxMin/MLWIzwI0UYq0hJt5iBHFTI9zASZUi WRlMFGadxUiMdesUm/yyH6laorWmzBVHnouEi0UxZRi3S+Vi8uaaS8MRsPuhCqpl3hzcur 8Pd700tvioZM3XF9QYLw4GcBaNDCkZovvW6iDP0vVTL0gOo0prf4vSm295yifAV84hYOfD 8YZbSSZcCXdFrLOUX3qzfGDwNoIIPgPULwQArD8X6zwR8kVB2jke9wDSAyCJIg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1695144742; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=C8niYpQTyqibS4DF87srHqtM3TVPvhAKHYuuhfsu6A4=; b=xquWigKx9Gm32Q+fALRDVzemy0OxRhEq2biOaijDZVzFLunBufDOsIF+zUt3KgV3oNf5wf kWpJXN8rfGFZPHG48nJm2QkKrTZEUGsHaoj/KIV9SCvEOPGPBfjSC2t144s+8kI9mXFxdH ek+TIpmU2ujLSjXN9KwVfRLo6RlsJ1ppaUKyx/D/ilSE74FOI7JdjHGRWOgRO3gYz6mK/m QxT2xe24fezJdCMD8TEtqKSuQ8/9HOid33wbBQnNsE/Iivecv3Nx6eDFPbaVx9yxdkAStz m6GdBhx2SSvMc5lujAykWq/9nFZBKvtN+8uEpszyg7PXnfCGSUkhQuapKSyg7g== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4RqpdL3ypDz7fv for ; Tue, 19 Sep 2023 17:32:22 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 38JHWMuV022900 for ; Tue, 19 Sep 2023 17:32:22 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 38JHWMX0022899 for ports-bugs@FreeBSD.org; Tue, 19 Sep 2023 17:32:22 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 261859] net-mgmt/unpoller: Collect unifi controller data (update MOVED for net-mgmt/unifi-poller) Date: Tue, 19 Sep 2023 17:32:22 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: feature X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: fuz@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: ports-bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Ports bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-ports-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ports-bugs@freebsd.org X-BeenThere: freebsd-ports-bugs@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D261859 Robert Clausecker changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fuz@FreeBSD.org --- Comment #3 from Robert Clausecker --- Thank you for your submission. I'm sorry this took so long to be processed= .=20 Here is some feedback on your submission: - it would be better to submit a separate port for md2roff and have it be a BUILD_DEPENDS. However, the current approach is ok, although it is unus= ual. - check if you can use the GO_MODULE mechanism and have the Go tooling download the dependencies automatically instead of manually listing all tuples. This is much easier to maintain in the long run. - please remove the "# Created by" comment. These have been removed from = the tree. New "Created by" headers will not be accepted. - the rc.d script must be designed such that it can cope with whatever PRE= FIX the user installs the package into. This is usually achieved through us= e of=20 the SUB_FILES mechanism, see USE_RC_SUBR in the Porter's Handbook. Please check that the rc.d script obeys PREFIX, USERS, and GROUPS. Ther= e's also a special rule with respect to installation directory for these, so make sure to do it properly. - instead of matching against DOCS in do-install, move the installation st= eps for documentation into do-install-DOCS-on. - please remove "WWW:" from pkg-descr and put it into the new WWW variable= in the Makefile. This is a recent change in the ports infrastructure. - please then extend pkg-descr to at least three lines. - you seem to be installing the sample configuration twice. Once is enoug= h. - please set LICENSE_FILE if possible. Please check these issues and resubmit. --=20 You are receiving this mail because: You are the assignee for the bug.=