[Bug 273461] [NEW PORT] irc/unreal current version of unrealircd

From: <bugzilla-noreply_at_freebsd.org>
Date: Sun, 10 Sep 2023 05:19:41 UTC

Robert Clausecker <fuz@FreeBSD.org> changed:

           What    |Removed                     |Added
             Status|New                         |Open
           Assignee|ports-bugs@FreeBSD.org      |fuz@FreeBSD.org

--- Comment #5 from Robert Clausecker <fuz@FreeBSD.org> ---
Thank you for the update.  This looks better!  Unfortunately I overlooked some
issues in my previous round that neverthless need to be addressed:

 - REINPLACE_CMD is not for static replacements; only use it for replacements
   where the text you want to insert is variable.  For static replacements, use
   patch files.  For configure scripts, it is usually best to add a patch for
   configure.ac and then to add USES=autoreconf to regenerate configure.

 - use the macros from ยง 5.17.1 Porter's Handbook (i.e. 
   files.  These macros differ in the permissions used and in whether to strip
   the file.

 - why do you install conf/examples/example.conf twice?  Once into the
   documentation and once into etc?

 - only config files the user is supposed to modify need @sample.  Please
   check which files these are and only use @sample for files the user is
   supposed to alter.

 - you could remove doc/ from the items in DOCS to make the list a bit shorter.

 - you can use .for ... .endfor loops to make the install target a bit shorter.

 - please place a blank line between the do-install and do-install-DOCS-on

 - the variable TMPDIR is used by various other bits of the build system.
   Please chose a different name (e.g. _TMPDIR) to avoid a collision.
   Alternatively, assign to it with ?= so the user's value is respected.

On another note, the port fails a build test (on arm64 FreeBSD 13.2) due to a
missing libargon2.  Perhaps you forgot to declare a dependency on it?

cc -I/wrkdirs/usr/ports/irc/unreal/work/unrealircd-
-D_THREAD_SAFE -pthread -I/usr/local/include
-O2 -pipe  -fstack-protector-strong -isystem /usr/local/include
-fno-strict-aliasing  -fno-strict-aliasing -fno-common -funsigned-char -Wall
-Wextra -Waggregate-return -Wformat-nonliteral -Wparentheses -Wno-pointer-sign
-Wno-invalid-source-encoding -Wno-format-zero-length -Wno-unused
-Wno-unused-parameter -Wno-unused-but-set-parameter -Wno-char-subscripts
-Wno-sign-compare -Wno-empty-body -Wno-unknown-warning-option 
-fno-strict-overflow -D_FORTIFY_SOURCE=2 -fstack-protector-all
-Wstack-protector --param ssp-buffer-size=1 -isystem /usr/local/include -fPIE
-lssl -lcrypto -ldl -o unrealircdctl unrealircdctl.o proc_io_client.o
ircd_vars.o dns.o auth.o channel.o crule.o dbuf.o fdlist.o hash.o ircsprintf.o
list.o match.o modules.o parse.o mempool.o operclass.o conf_preprocessor.o
conf.o proc_io_server.o debug.o dispatch.o securitygroup.o misc.o serv.o
aliases.o socket.o tls.o user.o scache.o send.o support.o version.o whowas.o
random.o api-usermode.o api-channelmode.o api-moddata.o api-extban.o
api-isupport.o api-command.o api-clicap.o api-messagetag.o
api-history-backend.o api-efunctions.o api-event.o api-rpc.o crypt_blowfish.o
unrealdb.o crashreport.o modulemanager.o utf8.o json.o log.o
openssl_hostname_validation.o url_unreal.o
-Wl,-rpath,/usr/local/share/unreal/lib  -Wl,-z,relro -Wl,-z,now  
-fstack-protector-strong  -Wl,-rpath,/usr/local/share/unreal/lib
-Wl,-export-dynamic -pie -lcrypt  -L/usr/local/lib -lpcre2-8
-L/usr/local/share/unreal/lib -largon2 -L/usr/local/lib -lcares
-L/usr/local/share/unreal/lib -lsodium -L/usr/local/share/unreal/lib -ljansson 
-lssl -lcrypto -ldl
ld: error: unable to find library -largon2
ld: error: unable to find library -largon2
cc: error: linker command failed with exit code 1 (use -v to see invocation)
cc: error: linker command failed with exit code 1 (use -v to see invocation)
gmake[3]: *** [Makefile:72: ircd] Error 1
gmake[3]: *** Waiting for unfinished jobs....
gmake[3]: *** [Makefile:75: unrealircdctl] Error 1
gmake[3]: Leaving directory
gmake[2]: *** [Makefile:65: build] Error 2
gmake[2]: Leaving directory
gmake[1]: *** [Makefile:141: build] Error 2
gmake[1]: Leaving directory
===> Compilation failed unexpectedly.

You are receiving this mail because:
You are the assignee for the bug.